[GitHub] [madlib] leskin-in commented on issue #479: Build: Determine architecture on Linux machines properly

[GitBox <gi...@apache.org>]

leskin-in commented on issue #479: Build: Determine architecture on Linux machines properly
URL: https://github.com/apache/madlib/pull/479#issuecomment-586151967
 
 
   The last commit https://github.com/apache/madlib/pull/479/commits/5fd815f2eb47ed15e0764f01c3178b73156d40fe is another way the architecture could be determined. `uname` produces shorter (machine-readable) and probably more consistent output.
   
   This change leads to substantial simplification of the `architecture()` CMake macro.
   
   However, this method to determine architecture is fundamentally different from the previously used one: `file` checks the actual Postgres / Greenplum binary, while `uname` outputs the architecture of the machine the build is run on. If the build is run on a machine whose architecture is different from the target one, `architecture()` would return incorrect results.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services