You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Steve Gill (JIRA)" <ji...@apache.org> on 2017/07/26 22:12:00 UTC

[jira] [Commented] (CB-12122) Incompatible plugin should make the build fail, not be skipped silently

    [ https://issues.apache.org/jira/browse/CB-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102363#comment-16102363 ] 

Steve Gill commented on CB-12122:
---------------------------------

It would need to be a major version of cordova. Chatted with Shaz & Simon and decided it would make sense to add a flag to current cordova that allows plugin add to fail if the dependency fails. So cordova@7 the default behavior will be skip the plugin or dep that doesn't satisfy the requirement and fail will be behind a flag. Once we hit cordova@8, we can swap the behavior so fail is default and skip is behind the flag. 

> Incompatible plugin should make the build fail, not be skipped silently
> -----------------------------------------------------------------------
>
>                 Key: CB-12122
>                 URL: https://issues.apache.org/jira/browse/CB-12122
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-cli, cordova-plugman
>    Affects Versions: 6.3.0
>            Reporter: 165537
>              Labels: backlog, cordova-8.0.0, tools-next
>
> When compiling (on Phonegap Build) a project containing a plugin which Cordova's version is incompatible, the plugin is silently skipped and the build is successful. Of course the functionalities of the plugin won't work in the app. Eg, here's what I got when compiling phonegap-plugin-push with Cordova 6.3.0:
> Fetching plugin "phonegap-plugin-push@1.9.0" via npm
> Installing "phonegap-plugin-push" at "1.9.0" for android
> Plugin doesn't support this project's cordova version. cordova: 6.3.2, failed version requirement: >=6.4.0
> Skipping 'phonegap-plugin-push' for android



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org