You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zhuoliu <gi...@git.apache.org> on 2015/09/24 18:22:54 UTC
[GitHub] storm pull request: [STORM-1068], configure request.required.acks ...
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/762
[STORM-1068], configure request.required.acks in KafkaUtilsTest
configure request.required.acks to be 1 in KafkaUtilsTest to make sure that the send() function gets synchronized to the broker for avoiding potential offset-out-of-range error.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 1068
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/762.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #762
----
commit d75e5fbed635a4c096c98d0abf25236c8616503d
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-09-24T16:20:37Z
STORM-1068, configure request.required.acks in KafkaUtilsTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1068], configure request.required.acks ...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/762#issuecomment-142980713
Looks OK to me. +1 pending travis CI build passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1068], configure request.required.acks ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---