You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2019/06/25 16:07:26 UTC
[native-toolchain-CR] SSL client support for THttpClient py implementation
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13725
Change subject: SSL client support for THttpClient py implementation
......................................................................
SSL client support for THttpClient py implementation
Thrift 0.9.3-p7 adds the ability to pass SSL context from the
clients for cert verification. This is needed for impala-shell
support for HTTP based server endpoints.
Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
---
M buildall.sh
A source/thrift/thrift-0.9.3-patches/0007-SSL-support-for-THttpClient-py-implementation.patch
2 files changed, 70 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/25/13725/1
--
To view, visit http://gerrit.cloudera.org:8080/13725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
Gerrit-Change-Number: 13725
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[native-toolchain-CR] SSL client support for THttpClient py implementation
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13725 )
Change subject: SSL client support for THttpClient py implementation
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
Gerrit-Change-Number: 13725
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 06:11:48 +0000
Gerrit-HasComments: No
[native-toolchain-CR] SSL client support for THttpClient py implementation
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13725
to look at the new patch set (#3).
Change subject: SSL client support for THttpClient py implementation
......................................................................
SSL client support for THttpClient py implementation
Thrift 0.9.3-p7 adds the ability to pass SSL context from the
clients for cert verification. This is needed for impala-shell
support for HTTP based server endpoints.
Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
---
M buildall.sh
A source/thrift/thrift-0.9.3-patches/0007-SSL-support-for-THttpClient-py.patch
2 files changed, 130 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/25/13725/3
--
To view, visit http://gerrit.cloudera.org:8080/13725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
Gerrit-Change-Number: 13725
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] SSL client support for THttpClient py implementation
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13725 )
Change subject: SSL client support for THttpClient py implementation
......................................................................
Patch Set 1:
Oops, I think I added the wrong patch file, let me fix that.
--
To view, visit http://gerrit.cloudera.org:8080/13725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
Gerrit-Change-Number: 13725
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 16:10:31 +0000
Gerrit-HasComments: No
[native-toolchain-CR] SSL client support for THttpClient py implementation
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13725 )
Change subject: SSL client support for THttpClient py implementation
......................................................................
Patch Set 3:
(1 comment)
I thought of doing that but I was afraid that it would cause any python 2.x incompatibilities.
http://gerrit.cloudera.org:8080/#/c/13725/2/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/13725/2/buildall.sh@166
PS2, Line 166: THRIFT_VERSION=0.9.3-p7 $SOURCE_DIR/source/thrift/build.sh
> I don't think we need to build all these thrift versions, do we? We should
Moved it under BUILD_HISTORICAL flag.
--
To view, visit http://gerrit.cloudera.org:8080/13725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
Gerrit-Change-Number: 13725
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 23:22:37 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] SSL client support for THttpClient py implementation
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13725 )
Change subject: SSL client support for THttpClient py implementation
......................................................................
Patch Set 2:
(1 comment)
I think this looks ok. I compared with the version of this file from thrift master and the key parts look consistent. I kinda wonder if it would have been easier to basically just take the file from new version of thrift instead of selectively picking changes, but I guess this reduces the chance of pulling in new problems.
http://gerrit.cloudera.org:8080/#/c/13725/2/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/13725/2/buildall.sh@166
PS2, Line 166: THRIFT_VERSION=0.9.3-p7 $SOURCE_DIR/source/thrift/build.sh
I don't think we need to build all these thrift versions, do we? We should be able to remove -p5 and -p6, I wouuld think
--
To view, visit http://gerrit.cloudera.org:8080/13725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
Gerrit-Change-Number: 13725
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 23:06:41 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] SSL client support for THttpClient py implementation
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13725 )
Change subject: SSL client support for THttpClient py implementation
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
Gerrit-Change-Number: 13725
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Jun 2019 15:43:59 +0000
Gerrit-HasComments: No
[native-toolchain-CR] SSL client support for THttpClient py implementation
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13725
to look at the new patch set (#2).
Change subject: SSL client support for THttpClient py implementation
......................................................................
SSL client support for THttpClient py implementation
Thrift 0.9.3-p7 adds the ability to pass SSL context from the
clients for cert verification. This is needed for impala-shell
support for HTTP based server endpoints.
Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
---
M buildall.sh
A source/thrift/thrift-0.9.3-patches/0007-SSL-support-for-THttpClient-py.patch
2 files changed, 128 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/25/13725/2
--
To view, visit http://gerrit.cloudera.org:8080/13725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
Gerrit-Change-Number: 13725
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] SSL client support for THttpClient py implementation
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13725 )
Change subject: SSL client support for THttpClient py implementation
......................................................................
SSL client support for THttpClient py implementation
Thrift 0.9.3-p7 adds the ability to pass SSL context from the
clients for cert verification. This is needed for impala-shell
support for HTTP based server endpoints.
Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
Reviewed-on: http://gerrit.cloudera.org:8080/13725
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Bharath Vissapragada <bh...@cloudera.com>
---
M buildall.sh
A source/thrift/thrift-0.9.3-patches/0007-SSL-support-for-THttpClient-py.patch
2 files changed, 130 insertions(+), 2 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Bharath Vissapragada: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0f76318aa18075b0e6e43aaf997b90e463228ce
Gerrit-Change-Number: 13725
Gerrit-PatchSet: 4
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>