You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Stepan Mishura <st...@gmail.com> on 2006/06/21 07:39:20 UTC

Re: svn commit: r415716 - in /incubator/harmony/enhanced/classlib/trunk/modules/security/src: main/java/common/java/security/AlgorithmParameterGenerator.java test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Te

Hi Tim,

AlgorithmParameterGenerator.init(int) doesn't declare exceptions to be
thrown[1].

Thanks,
Stepan.

[1]
http://java.sun.com/j2se/1.5.0/docs/api/java/security/AlgorithmParameterGenerator.html#init(int
)


-----Original Message-----
From: tellison@apache.org [mailto:tellison@apache.org]
Sent: Tuesday, June 20, 2006 10:55 PM
To: harmony-commits@incubator.apache.org
Subject: svn commit: r415716 - in
/incubator/harmony/enhanced/classlib/trunk/modules/security/src:
main/java/common/java/security/AlgorithmParameterGenerator.java
test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java



Author: tellison

Date: Tue Jun 20 08:54:49 2006

New Revision: 415716



URL: http://svn.apache.org/viewvc?rev=415716&view=rev

Log:

Add exception throws declaration as in spec.



Modified:


incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/AlgorithmParameterGenerator.java


incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java



Modified:
incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/AlgorithmParameterGenerator.java

URL:
http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/AlgorithmParameterGenerator.java?rev=415716&r1=415715&r2=415716&view=diff

==============================================================================

---
incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/AlgorithmParameterGenerator.java
(original)

+++
incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/AlgorithmParameterGenerator.java
Tue Jun 20 08:54:49 2006

@@ -143,7 +143,7 @@

      * @com.intel.drl.spec_ref

      *

      */

-    public final void init(int size) {

+    public final void init(int size) throws
InvalidAlgorithmParameterException {

         spiImpl.engineInit(size, randm);

     }





Modified:
incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java

URL:
http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java?rev=415716&r1=415715&r2=415716&view=diff

==============================================================================

---
incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java
(original)

+++
incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java
Tue Jun 20 08:54:49 2006

@@ -306,7 +306,7 @@

      * Assertion: returns AlgorithmParameters object

      */

     public void testAlgorithmParameterGenerator10()

-            throws NoSuchAlgorithmException {

+            throws NoSuchAlgorithmException,
InvalidAlgorithmParameterException {

         if (!DSASupported) {

             fail(validAlgName + " algorithm is not supported");

             return;

------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org

Re: svn commit: r415716 - in /incubator/harmony/enhanced/classlib/trunk/modules/security/src: main/java/common/java/security/AlgorithmParameterGenerator.java test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Te

Posted by Tim Ellison <t....@gmail.com>.
Oops, thanks for catching that Stepan,

Looking again I was reading this version:

public final void init(AlgorithmParameterSpec genParamSpec)
                throws InvalidAlgorithmParameterException


I'll back out that change.

Regards,
Tim


Stepan Mishura wrote:
> Hi Tim,
> 
> AlgorithmParameterGenerator.init(int) doesn't declare exceptions to be
> thrown[1].
> 
> Thanks,
> Stepan.
> 
> [1]
> http://java.sun.com/j2se/1.5.0/docs/api/java/security/AlgorithmParameterGenerator.html#init(int
> 
> )
> 
> 
> -----Original Message-----
> From: tellison@apache.org [mailto:tellison@apache.org]
> Sent: Tuesday, June 20, 2006 10:55 PM
> To: harmony-commits@incubator.apache.org
> Subject: svn commit: r415716 - in
> /incubator/harmony/enhanced/classlib/trunk/modules/security/src:
> main/java/common/java/security/AlgorithmParameterGenerator.java
> test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java
> 
> 
> 
> 
> Author: tellison
> 
> Date: Tue Jun 20 08:54:49 2006
> 
> New Revision: 415716
> 
> 
> 
> URL: http://svn.apache.org/viewvc?rev=415716&view=rev
> 
> Log:
> 
> Add exception throws declaration as in spec.
> 
> 
> 
> Modified:
> 
> 
> incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/AlgorithmParameterGenerator.java
> 
> 
> 
> incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java
> 
> 
> 
> 
> Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/AlgorithmParameterGenerator.java
> 
> 
> URL:
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/AlgorithmParameterGenerator.java?rev=415716&r1=415715&r2=415716&view=diff
> 
> 
> ==============================================================================
> 
> 
> ---
> incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/AlgorithmParameterGenerator.java
> 
> (original)
> 
> +++
> incubator/harmony/enhanced/classlib/trunk/modules/security/src/main/java/common/java/security/AlgorithmParameterGenerator.java
> 
> Tue Jun 20 08:54:49 2006
> 
> @@ -143,7 +143,7 @@
> 
>      * @com.intel.drl.spec_ref
> 
>      *
> 
>      */
> 
> -    public final void init(int size) {
> 
> +    public final void init(int size) throws
> InvalidAlgorithmParameterException {
> 
>         spiImpl.engineInit(size, randm);
> 
>     }
> 
> 
> 
> 
> 
> Modified:
> incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java
> 
> 
> URL:
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java?rev=415716&r1=415715&r2=415716&view=diff
> 
> 
> ==============================================================================
> 
> 
> ---
> incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java
> 
> (original)
> 
> +++
> incubator/harmony/enhanced/classlib/trunk/modules/security/src/test/api/java/org/apache/harmony/security/tests/java/security/AlgorithmParameterGenerator1Test.java
> 
> Tue Jun 20 08:54:49 2006
> 
> @@ -306,7 +306,7 @@
> 
>      * Assertion: returns AlgorithmParameters object
> 
>      */
> 
>     public void testAlgorithmParameterGenerator10()
> 
> -            throws NoSuchAlgorithmException {
> 
> +            throws NoSuchAlgorithmException,
> InvalidAlgorithmParameterException {
> 
>         if (!DSASupported) {
> 
>             fail(validAlgName + " algorithm is not supported");
> 
>             return;
> 
> ------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 

-- 

Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org