[GitHub] [airflow] jedcunningham commented on a diff in pull request #29743: Fix on_failure_callback when task receives a SIGTERM

["jedcunningham (via GitHub)" <gi...@apache.org>]

jedcunningham commented on code in PR #29743:
URL: https://github.com/apache/airflow/pull/29743#discussion_r1117214964


##########
airflow/exceptions.py:
##########
@@ -29,6 +29,12 @@
     from airflow.models import DagRun
 
 
+class AirflowKillSignal(Exception):
+    """Raise when there's kill signal"""

Review Comment:
   ```suggestion
   class AirflowTermSignal(Exception):
       """Raise when we receive a TERM signal"""
   ```
   
   We should consider using something other than "kill" here, as a true SIGKILL won't hit this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org