You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/15 23:47:41 UTC
[GitHub] codecov-io commented on issue #5641: Field names in big query can
contain only alphanumeric and underscore
codecov-io commented on issue #5641: Field names in big query can contain only alphanumeric and underscore
URL: https://github.com/apache/incubator-superset/pull/5641#issuecomment-413375073
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5641?src=pr&el=h1) Report
> Merging [#5641](https://codecov.io/gh/apache/incubator-superset/pull/5641?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5966a674e57240852c853d2b14cbf7675c77a134?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `45.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5641?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5641 +/- ##
=========================================
- Coverage 63.51% 63.5% -0.01%
=========================================
Files 360 360
Lines 22890 22901 +11
Branches 2549 2549
=========================================
+ Hits 14539 14544 +5
- Misses 8336 8342 +6
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `78.74% <100%> (+0.08%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5641/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `54.03% <33.33%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5641?src=pr&el=footer). Last update [5966a67...7a5d1c7](https://codecov.io/gh/apache/incubator-superset/pull/5641?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org