You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/05/31 05:43:31 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new pull request, #2787: [KYUUBI #2643][FOLLOWUP] Using javax.security.sasl.AuthenticationException instead of hadoop AuthenticationException
turboFei opened a new pull request, #2787:
URL: https://github.com/apache/incubator-kyuubi/pull/2787
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2787: [KYUUBI #2643][FOLLOWUP] Using javax AuthenticationException instead of hadoop AuthenticationException
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #2787:
URL: https://github.com/apache/incubator-kyuubi/pull/2787#issuecomment-1141854423
The UserGroupInformation may also be replaced by jdk Subject?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2787: [KYUUBI #2643][FOLLOWUP] Using javax AuthenticationException instead of hadoop AuthenticationException
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2787:
URL: https://github.com/apache/incubator-kyuubi/pull/2787#issuecomment-1147518042
> seems we can remove hadoop dependency in pom ?
It is still used here.
https://github.com/apache/incubator-kyuubi/pull/2787/files#diff-282b1e8c3fee6a8b8b6814d201ba42ad60fc1a1b5546fcc2a31150f3e5ff89abR46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2787: [KYUUBI #2643][FOLLOWUP] Using javax AuthenticationException instead of hadoop AuthenticationException
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2787:
URL: https://github.com/apache/incubator-kyuubi/pull/2787#issuecomment-1141733462
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2787?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2787](https://codecov.io/gh/apache/incubator-kyuubi/pull/2787?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (796ff2e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/a04afabddb52db11bacd1f8d145327f72edc8162?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a04afab) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #2787 +/- ##
=========================================
Coverage 62.16% 62.16%
Complexity 201 201
=========================================
Files 463 463
Lines 20815 20815
Branches 2808 2808
=========================================
Hits 12939 12939
Misses 6620 6620
Partials 1256 1256
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/kyuubi/client/util/AuthUtil.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L3V0aWwvQXV0aFV0aWwuamF2YQ==) | `84.00% <0.00%> (ø)` | |
| [.../org/apache/kyuubi/engine/jdbc/JdbcSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1qZGJjLWVuZ2luZS9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvamRiYy9KZGJjU1FMRW5naW5lLnNjYWxh) | `51.51% <0.00%> (-3.04%)` | :arrow_down: |
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2787/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `69.33% <0.00%> (+1.33%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2787?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2787?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a04afab...796ff2e](https://codecov.io/gh/apache/incubator-kyuubi/pull/2787?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2787: [KYUUBI #2643][FOLLOWUP] Using javax AuthenticationException instead of hadoop AuthenticationException
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2787:
URL: https://github.com/apache/incubator-kyuubi/pull/2787#issuecomment-1145860955
> The UserGroupInformation may also be replaced by jdk Subject?
Seems difficult to do that if user use `UserGroupInformation.setLoginUser(loginUser)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2787: [KYUUBI #2643][FOLLOWUP] Using javax AuthenticationException instead of hadoop AuthenticationException
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2787:
URL: https://github.com/apache/incubator-kyuubi/pull/2787#issuecomment-1149397197
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2787: [KYUUBI #2643][FOLLOWUP] Using javax AuthenticationException instead of hadoop AuthenticationException
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #2787:
URL: https://github.com/apache/incubator-kyuubi/pull/2787#issuecomment-1146957317
seems we can remove hadoop dependency in pom ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #2787: [KYUUBI #2643][FOLLOWUP] Using javax AuthenticationException instead of hadoop AuthenticationException
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #2787: [KYUUBI #2643][FOLLOWUP] Using javax AuthenticationException instead of hadoop AuthenticationException
URL: https://github.com/apache/incubator-kyuubi/pull/2787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2787: [KYUUBI #2643][FOLLOWUP] Using javax AuthenticationException instead of hadoop AuthenticationException
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2787:
URL: https://github.com/apache/incubator-kyuubi/pull/2787#issuecomment-1149416017
thanks for your review @ulysses-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org