You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2019/12/16 23:57:00 UTC

[jira] [Commented] (SOLR-14057) simplify a directive in LTR ref guide

    [ https://issues.apache.org/jira/browse/SOLR-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997720#comment-16997720 ] 

David Smiley commented on SOLR-14057:
-------------------------------------

I don't think your change would work.  You used the "dir" attribute on the lib XML element when I think "path" is appropriate since we are referring to one specific path (not all child dirs beneath).

> simplify a <lib/> directive in LTR ref guide
> --------------------------------------------
>
>                 Key: SOLR-14057
>                 URL: https://issues.apache.org/jira/browse/SOLR-14057
>             Project: Solr
>          Issue Type: Task
>          Components: contrib - LTR
>            Reporter: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-14057.patch
>
>
> In the [https://lucene.apache.org/solr/guide/8_3/learning-to-rank.html#using-large-models] section we currently have
> {code:java}
> <lib dir="/path/to" regex="models" />
> {code}
> and as was mentioned today to me the use of a regex here is confusing (since it's not actually a regex as such).
> The test files just use a path and also helpfully have a comment re: the purpose of the lib directive: [https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.3.1/solr/contrib/ltr/src/test-files/solr/collection1/conf/solrconfig-ltr.xml#L19-L20]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org