[GitHub] [ozone] neils-dev commented on a diff in pull request #4044: HDDS-7517. Register OM-S3G gRPC performance metrics

["neils-dev (via GitHub)" <gi...@apache.org>]

neils-dev commented on code in PR #4044:
URL: https://github.com/apache/ozone/pull/4044#discussion_r1110430866


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/GrpcOzoneManagerServer.java:
##########
@@ -91,9 +97,15 @@ public void init(OzoneManagerProtocolServerSideTranslatorPB omTranslator,
                    CertificateClient caClient) {
     NettyServerBuilder nettyServerBuilder = NettyServerBuilder.forPort(port)
         .maxInboundMessageSize(maxSize)
-        .addService(new OzoneManagerServiceGrpc(omTranslator,
-            delegationTokenMgr,
-            omServerConfig));
+        .maxConnectionIdle(CLIENT_TIMEOUT_SECS, TimeUnit.SECONDS)

Review Comment:
   This timeout is questionable.  What is the reason for this.  Offline we had a discussion to not have a timeout.  Can we remove the timeout?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org