[GitHub] [spark] hvanhovell commented on a diff in pull request #43195: [SPARK-45371][CONNECT] Fix shading issues in the Spark Connect Scala Client

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #43195:
URL: https://github.com/apache/spark/pull/43195#discussion_r1342274068


##########
connector/connect/client/jvm/pom.xml:
##########
@@ -85,59 +95,70 @@
         <artifactId>maven-shade-plugin</artifactId>
         <configuration>
           <shadedArtifactAttached>false</shadedArtifactAttached>
+          <promoteTransitiveDependencies>true</promoteTransitiveDependencies>
           <artifactSet>
             <includes>
               <include>com.google.android:*</include>
               <include>com.google.api.grpc:*</include>
               <include>com.google.code.findbugs:*</include>
               <include>com.google.code.gson:*</include>
               <include>com.google.errorprone:*</include>
-              <include>com.google.guava:*</include>

Review Comment:
   Guava in included by the parent pom.xml.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org