You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/11/06 21:15:50 UTC

[GitHub] [incubator-echarts] 100pah opened a new pull request #11574: fix: fix bar width strategy.

100pah opened a new pull request #11574: fix: fix bar width strategy.
URL: https://github.com/apache/incubator-echarts/pull/11574
 
 
   
   fix: fix bar width strategy.
   
   (1) On value axis, the auto-calculated bar width might be near 0, which make the bar invisible.
   So we add option `barMinWidth` (default 1 in category and default null in other coord sys).
   
   (2) In #5316 (commit 2823ab502bf1af27c33de6d09729bc287ef0a185) the fix seems not correct.
   check the "main3" case in `echarts/test/bar-width.html`. That fix would made the `barMaxWidth` has
   higher priority than `barWidth`. But it only works when auto-calculated bar width is bigger than the 
   giving `barWidth`. So the behavior seems weird. 
   This fix revert it and use the strategy: `barWidth` always has higher priority than `barMaxWidth`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org