You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tweise <gi...@git.apache.org> on 2018/05/23 02:18:06 UTC

[GitHub] flink pull request #6058: [FLINK-9415] Remove reference to StreamingMultiple...

GitHub user tweise opened a pull request:

    https://github.com/apache/flink/pull/6058

    [FLINK-9415] Remove reference to StreamingMultipleProgramsTestBase in docs

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tweise/flink FLINK-9415.StreamingMultipleProgramsTestBase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6058.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6058
    
----
commit 68c8db890ba939a03ce324d905530ac057eff932
Author: Thomas Weise <th...@...>
Date:   2018-05-23T02:15:57Z

    [FLINK-9415] Remove reference to StreamingMultipleProgramsTestBase in docs

----


---

[GitHub] flink issue #6058: [FLINK-9415] Remove reference to StreamingMultipleProgram...

Posted by tweise <gi...@git.apache.org>.

Github user tweise commented on the issue:

    https://github.com/apache/flink/pull/6058
  
    @tzulitai PTAL


---

[GitHub] flink pull request #6058: [FLINK-9415] Remove reference to StreamingMultiple...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6058


---

[GitHub] flink pull request #6058: [FLINK-9415] Remove reference to StreamingMultiple...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6058#discussion_r190139650
  
    --- Diff: docs/dev/stream/testing.md ---
    @@ -181,7 +181,7 @@ public class ExampleIntegrationTest extends StreamingMultipleProgramsTestBase {
     
     <div data-lang="scala" markdown="1">
     {% highlight scala %}
    -class ExampleIntegrationTest extends StreamingMultipleProgramsTestBase {
    +class ExampleIntegrationTest extends ScalaStreamingMultipleProgramsTestBase {
    --- End diff --
    
    yes i agree, let's modify the docs to mention `AbstractTestBase` and remove `ScalaStreamingMultipleProgramsTestBase` in a separate issue.


---

[GitHub] flink issue #6058: [FLINK-9415] Remove reference to StreamingMultipleProgram...

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/6058
  
    +1, LGTM
    Merging this ..


---

[GitHub] flink pull request #6058: [FLINK-9415] Remove reference to StreamingMultiple...

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6058#discussion_r190123818
  
    --- Diff: docs/dev/stream/testing.md ---
    @@ -181,7 +181,7 @@ public class ExampleIntegrationTest extends StreamingMultipleProgramsTestBase {
     
     <div data-lang="scala" markdown="1">
     {% highlight scala %}
    -class ExampleIntegrationTest extends StreamingMultipleProgramsTestBase {
    +class ExampleIntegrationTest extends ScalaStreamingMultipleProgramsTestBase {
    --- End diff --
    
    I see that in the code we still have only 1 usage of `ScalaStreamingMultipleProgramsTestBase`, but I don't see why it can't be replaced with `AbstractTestBase` also (therefore removing `ScalaStreamingMultipleProgramsTestBase` and not referencing it anymore in docs).
    
    @zentol could you comment here?


---

[GitHub] flink pull request #6058: [FLINK-9415] Remove reference to StreamingMultiple...

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6058#discussion_r190123863
  
    --- Diff: docs/dev/stream/testing.md ---
    @@ -181,7 +181,7 @@ public class ExampleIntegrationTest extends StreamingMultipleProgramsTestBase {
     
     <div data-lang="scala" markdown="1">
     {% highlight scala %}
    -class ExampleIntegrationTest extends StreamingMultipleProgramsTestBase {
    +class ExampleIntegrationTest extends ScalaStreamingMultipleProgramsTestBase {
    --- End diff --
    
    I see that in the code we still have only 1 usage of `ScalaStreamingMultipleProgramsTestBase`, but I don't see why it can't be replaced with `AbstractTestBase` also (therefore removing `ScalaStreamingMultipleProgramsTestBase` and not referencing it anymore in docs).
    
    @zentol could you comment here?


---