You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shauryachats (via GitHub)" <gi...@apache.org> on 2025/08/12 18:29:12 UTC
[PR] [timeseries][ui] Add configurable max series limit for timeseries chart visualization [pinot]
shauryachats opened a new pull request, #16580:
URL: https://github.com/apache/pinot/pull/16580
## Summary
This PR replaces the fixed `MAX_SERIES_LIMIT` restriction with a user-configurable input on the Timeseries Query page. Users can now adjust the number of series displayed in the chart, with truncation warnings updated accordingly.
Removed the series limit enforcement from TimeseriesChart itself, moving it to TimeseriesQueryPage for greater flexibility and control.
Also added UI tweaks for the input field and improved layout handling.
## Testing
Successfully tested on timeseries quickstart to validate that feature is correctly working.
https://github.com/user-attachments/assets/63e135de-7b90-4bf3-8197-2477cb8ba67b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [timeseries][ui] Add configurable max series limit for timeseries chart visualization [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #16580:
URL: https://github.com/apache/pinot/pull/16580#issuecomment-3180696585
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/16580?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.35%. Comparing base ([`08b76f1`](https://app.codecov.io/gh/apache/pinot/commit/08b76f1aa50ab0bb549ee2648c53f89a0370f6fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e51672c`](https://app.codecov.io/gh/apache/pinot/commit/e51672c0b892241637a0af152066d7acbf8345d0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (08b76f1) and HEAD (e51672c). Click for more details.
>
> <details><summary>HEAD has 32 uploads less than BASE</summary>
>
>| Flag | BASE (08b76f1) | HEAD (e51672c) |
>|------|------|------|
>|java-21|5|1|
>|unittests1|2|1|
>|unittests|4|1|
>|temurin|9|1|
>|unittests2|2|0|
>|java-11|4|0|
>|integration|5|0|
>|integration1|2|0|
>|custom-integration1|2|0|
>|integration2|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16580 +/- ##
============================================
- Coverage 63.30% 56.35% -6.95%
+ Complexity 1380 699 -681
============================================
Files 3014 2358 -656
Lines 174662 129827 -44835
Branches 26758 20657 -6101
============================================
- Hits 110562 73165 -37397
+ Misses 55678 50626 -5052
+ Partials 8422 6036 -2386
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.35% <ø> (-6.92%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.35% <ø> (-6.95%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.35% <ø> (-6.95%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.35% <ø> (-0.07%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/16580/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/16580?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [timeseries][ui] Add configurable max series limit for timeseries chart visualization [pinot]
Posted by "ankitsultana (via GitHub)" <gi...@apache.org>.
ankitsultana commented on code in PR #16580:
URL: https://github.com/apache/pinot/pull/16580#discussion_r2271165416
##########
pinot-controller/src/main/resources/app/components/Query/TimeseriesQueryPage.tsx:
##########
@@ -560,23 +579,37 @@ const TimeseriesQueryPage = () => {
<SimpleAccordion
headerTitle="Timeseries Chart & Statistics"
showSearchBox={false}
+ detailsContainerClass={classes.timeseriesAccordionDetails}
>
- {truncatedChartSeries.length > 0 ? (
+ {chartSeries.length > 0 ? (
<>
<TruncationWarning
- totalSeries={chartSeries.length}
- truncatedSeries={truncatedChartSeries.length}
+ totalSeries={totalSeriesCount}
+ truncatedSeries={chartSeries.length}
/>
<TimeseriesChart
- series={truncatedChartSeries}
+ series={chartSeries}
height={500}
selectedMetric={selectedMetric}
/>
<MetricStatsTable
- series={truncatedChartSeries}
+ series={chartSeries}
selectedMetric={selectedMetric}
onMetricSelect={setSelectedMetric}
/>
+ <div className={classes.seriesLimitContainer}>
+ <Typography variant="body2" color="textSecondary">
+ Max Series Limit:
Review Comment:
nit: can you call this `Max Series Render Limit`? To avoid confusion with series limit knobs in the query API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [timeseries][ui] Add configurable max series limit for timeseries chart visualization [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #16580:
URL: https://github.com/apache/pinot/pull/16580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org