[jira] [Comment Edited] (BEAM-7762) Stop shading protobuf in Beam SQL

["Andrew Pilloud (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887381#comment-16887381 ] 

Andrew Pilloud edited comment on BEAM-7762 at 7/17/19 7:52 PM:
---------------------------------------------------------------

This actually breaks some things:

org.apache.beam.sdk.extensions.sql.jdbc.JdbcJarTest.classLoader_simple
org.apache.beam.sdk.extensions.sql.jdbc.JdbcJarTest.classLoader_parse
org.apache.beam.sdk.extensions.sql.jdbc.JdbcJarTest.classLoader_readFile
org.apache.beam.sdk.extensions.sql.jdbc.JdbcJarTest.classLoader_ddl

That means we do need to keep shading, which is going to further complicate using ZetaSQL, which has Protobuf on its public API surface. (Using vendored Protobuf isn't possible because of this.)


was (Author: apilloud):
This actually breaks some things:


> Stop shading protobuf in Beam SQL
> ---------------------------------
>
>                 Key: BEAM-7762
>                 URL: https://issues.apache.org/jira/browse/BEAM-7762
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: Andrew Pilloud
>            Assignee: Andrew Pilloud
>            Priority: Major
>
> Protobuf is on the public API surface of SQL. It is in our config as shaded, but doesn't need to be anymore. We should stop doing so as it will enable easier integration with ZetaSQL, which has Protobuf on its public API surface.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)