[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1891: serial: Shouldn't mangle pid when ISIG is changed

[GitBox <gi...@apache.org>]

xiaoxiang781216 edited a comment on pull request #1891:
URL: https://github.com/apache/incubator-nuttx/pull/1891#issuecomment-698441535


   > @xiaoxiang781216 - I would need more context here.
   
   from https://man7.org/linux/man-pages/man3/termios.3.html:
   ```
   ISIG   When any of the characters INTR, QUIT, SUSP, or DSUSP are
                 received, generate the corresponding signal.
   ```
   When ISIG is clear, serial driver should skip the signal generation code. The old implementattion achieve this behaviour by changing pid to -1, but it isn't good to modify the value provided by user without caution. So this PR check ISIG directly instead and keep pid intact.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org