You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/26 04:27:59 UTC
[GitHub] [netbeans] jGauravGupta opened a new pull request, #4687: Jakarta EE 10 - JPA 3.1 support
jGauravGupta opened a new pull request, #4687:
URL: https://github.com/apache/netbeans/pull/4687
Signed-off-by: Gaurav Gupta <ga...@payara.fish>
This PR adds support for JPA 2.2, JPA 3.0, and JPA 3.1 to enable the visual editor for the `persistence.xml` deployment descriptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#issuecomment-1374411480
@jGauravGupta is this still WIP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#issuecomment-1475404243
I think this PR is ready. When using JPA 3.0 or 3.1 the namespace will be `jakarta.persistence.`; if not it will use `javax.persistence.`
JPA 3.0 with EclipseLink provider
JPA 2.2 with OpenJPA provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#issuecomment-1505869478
This is marked as reviewed, I eyeballed it today and it looked sane, so I'll merge this sometime next weekend before branch of NB18. If someone wants to intervene, now would be a good time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on a diff in pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on code in PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#discussion_r1136562222
##########
java/j2ee.persistence/licenseinfo.xml:
##########
@@ -71,6 +71,13 @@
</license>
<comment type="CATEGORY_B">Used for XML Validation and code completion at runtime.</comment>
</fileset>
+ <fileset>
+ <file>src/org/netbeans/modules/j2ee/persistence/dd/resources/orm_3_1.xsd</file>
Review Comment:
orm 3.1 is already in this file, see line 67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #4687:
URL: https://github.com/apache/netbeans/pull/4687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] nicolaken commented on pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by GitBox <gi...@apache.org>.
nicolaken commented on PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#issuecomment-1386636363
Hi @jGauravGupta, what is still missing?
I do not no much about the Netbeans codebase and I had tried to do something about this problem, but now that I see how many files you have touched, I understand why I failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on a diff in pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on code in PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#discussion_r1136417925
##########
enterprise/glassfish.javaee/src/org/netbeans/modules/glassfish/javaee/Hk2JpaSupportImpl.java:
##########
@@ -97,10 +109,12 @@ private static class JpaSupportVector {
static {
for (GlassFishVersion version : GlassFishVersion.values()) {
jpaSupport[version.ordinal()] = new JpaSupportVector(
- GlassFishVersion.lt(version, GlassFishVersion.GF_6),
- GlassFishVersion.lt(version, GlassFishVersion.GF_6) && GlassFishVersion.ge(version, GlassFishVersion.GF_3),
- GlassFishVersion.lt(version, GlassFishVersion.GF_6) && GlassFishVersion.ge(version, GlassFishVersion.GF_4),
- GlassFishVersion.lt(version, GlassFishVersion.GF_6) && GlassFishVersion.ge(version, GlassFishVersion.GF_5)
+ GlassFishVersion.lt(version, GlassFishVersion.GF_7_0_0),
+ GlassFishVersion.lt(version, GlassFishVersion.GF_7_0_0) && GlassFishVersion.ge(version, GlassFishVersion.GF_3),
+ GlassFishVersion.lt(version, GlassFishVersion.GF_7_0_0) && GlassFishVersion.ge(version, GlassFishVersion.GF_4),
+ GlassFishVersion.lt(version, GlassFishVersion.GF_7_0_0) && GlassFishVersion.ge(version, GlassFishVersion.GF_5),
Review Comment:
JPA 1.0, 2.0, 2.1 and 2.2 are not supported by GlassFish 6 and upward, so the comparison for JPA below 3.0 should be against `GlassFishVersion.GF_6`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#issuecomment-1510382647
Lets get this in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#issuecomment-1499423619
@pepness @jGauravGupta it would be good to get this merged shortly, could two please check if you want to cleanup the commits or merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jGauravGupta commented on pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by GitBox <gi...@apache.org>.
jGauravGupta commented on PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#issuecomment-1386613480
Hi @mbien ,
Yes, I will resume the work on this PR. It can probably be targeted for NB18.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#discussion_r1129859348
##########
java/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/provider/Provider.java:
##########
@@ -83,7 +83,11 @@ public boolean isOnClassPath(ClassPath cp)
boolean ret = cp.findResource(classRelativePath) != null;
if(ret && version != null)
{
- if (Persistence.VERSION_2_2.equals(version)) {
+ if(Persistence.VERSION_3_1.equals(version)){
+ ret &= cp.findResource("jakarta/persistence/spi/TransformerException.class.class") != null;
+ } else if(Persistence.VERSION_3_0.equals(version)){
+ ret &= cp.findResource("jakarta/persistence/Entity.class") != null;
+ | else if (Persistence.VERSION_2_2.equals(version)) {
Review Comment:
typo `|` ->` }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4687: Jakarta EE 10 - JPA 3.1 support
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4687:
URL: https://github.com/apache/netbeans/pull/4687#issuecomment-1461518418
sounds like this would fix #3756?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists