You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/05 07:54:58 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new issue #11658: Load metadata,ShardingTableMetaDataBuilder#parallelLoadTables performance waste.
tuichenchuxin opened a new issue #11658:
URL: https://github.com/apache/shardingsphere/issues/11658
## Feature Request
### Is your feature request related to a problem?
not a problem, but a little performance waste about
### Describe the feature you would like.
sharding config, when i make `check-table-metadata-enabled: true`
then it'll go through `TableMetaDataBuilder#parallelLoadTables`
Then i found tableFutureMap will throw away some future, which is already load table.
If I want to check whether the tables of all data nodes are consistent, then I shouldn't just use the table name as the key.
If I just want to check all the tables on one node, then I shouldn't load all the nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero closed issue #11658: Load metadata,ShardingTableMetaDataBuilder#parallelLoadTables performance waste.
Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #11658:
URL: https://github.com/apache/shardingsphere/issues/11658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on issue #11658: Load metadata,ShardingTableMetaDataBuilder#parallelLoadTables performance waste.
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on issue #11658:
URL: https://github.com/apache/shardingsphere/issues/11658#issuecomment-893285059
I found `MetaDataContextsBuilder#buildSchema` has useless line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on issue #11658: Load metadata,ShardingTableMetaDataBuilder#parallelLoadTables performance waste.
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on issue #11658:
URL: https://github.com/apache/shardingsphere/issues/11658#issuecomment-899029136
@tristaZero Not yet. After the dialect loading rule tables and the single tables are completed, the parallel check logic will be refactored, and the dialect loading method will be introduced. This problem will be fixed at that time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on issue #11658: Load metadata,ShardingTableMetaDataBuilder#parallelLoadTables performance waste.
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on issue #11658:
URL: https://github.com/apache/shardingsphere/issues/11658#issuecomment-893285059
I found `MetaDataContextsBuilder#buildSchema` has useless line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #11658: Load metadata,ShardingTableMetaDataBuilder#parallelLoadTables performance waste.
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #11658:
URL: https://github.com/apache/shardingsphere/issues/11658#issuecomment-899024852
? So is it fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org