You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Mark Weitzel (JIRA)" <ji...@apache.org> on 2011/01/07 20:25:45 UTC
[jira] Created: (SHINDIG-1485) Relative URLs in embed tags are not
properly rewritten.
Relative URLs in embed tags are not properly rewritten.
-------------------------------------------------------
Key: SHINDIG-1485
URL: https://issues.apache.org/jira/browse/SHINDIG-1485
Project: Shindig
Issue Type: Bug
Components: Java
Affects Versions: 2.0.3, 3.0.0
Environment: All
Reporter: Mark Weitzel
Priority: Minor
Fix For: 2.0.3, 3.0.0
Relative URLs in embed tags are not properly rewritten.
This was discovered when trying to work with an .swf file.An embed tag's relative URL is not being properly rewritten. However, as a test, if you simply changed the tag to be an img, the it worked.
I'll attach a patch that should fix this problem by adding embed to AbsolutePathReferenceVisitor
The discussion thread on shidig dev is here:
http://mail-archives.apache.org/mod_mbox/shindig-dev/201101.mbox/ajax/%3CC94BD537.3D65%mark.weitzel@jivesoftware.com%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1485) Relative URLs in embed tags are
not properly rewritten.
Posted by "Han Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979036#action_12979036 ]
Han Nguyen commented on SHINDIG-1485:
-------------------------------------
lgtm, will commit
> Relative URLs in embed tags are not properly rewritten.
> -------------------------------------------------------
>
> Key: SHINDIG-1485
> URL: https://issues.apache.org/jira/browse/SHINDIG-1485
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.3, 3.0.0
> Environment: All
> Reporter: Mark Weitzel
> Priority: Minor
> Fix For: 2.0.3, 3.0.0
>
> Attachments: embedTagUrl.patch
>
>
> Relative URLs in embed tags are not properly rewritten.
> This was discovered when trying to work with an .swf file.An embed tag's relative URL is not being properly rewritten. However, as a test, if you simply changed the tag to be an img, the it worked.
> I'll attach a patch that should fix this problem by adding embed to AbsolutePathReferenceVisitor
> The discussion thread on shidig dev is here:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201101.mbox/ajax/%3CC94BD537.3D65%mark.weitzel@jivesoftware.com%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1485) Relative URLs in embed tags are
not properly rewritten.
Posted by "Mark Weitzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978931#action_12978931 ]
Mark Weitzel commented on SHINDIG-1485:
---------------------------------------
Here's the URL for the discussion:
http://mail-archives.apache.org/mod_mbox/shindig-dev/201101.mbox/%3CC94BD537.3D65%25mark.weitzel@jivesoftware.com%3E
> Relative URLs in embed tags are not properly rewritten.
> -------------------------------------------------------
>
> Key: SHINDIG-1485
> URL: https://issues.apache.org/jira/browse/SHINDIG-1485
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.3, 3.0.0
> Environment: All
> Reporter: Mark Weitzel
> Priority: Minor
> Fix For: 2.0.3, 3.0.0
>
> Attachments: embedTagUrl.patch
>
>
> Relative URLs in embed tags are not properly rewritten.
> This was discovered when trying to work with an .swf file.An embed tag's relative URL is not being properly rewritten. However, as a test, if you simply changed the tag to be an img, the it worked.
> I'll attach a patch that should fix this problem by adding embed to AbsolutePathReferenceVisitor
> The discussion thread on shidig dev is here:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201101.mbox/ajax/%3CC94BD537.3D65%mark.weitzel@jivesoftware.com%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-1485) Relative URLs in embed tags are not
properly rewritten.
Posted by "Han Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Han Nguyen closed SHINDIG-1485.
-------------------------------
Resolution: Fixed
It's in trunk now.
> Relative URLs in embed tags are not properly rewritten.
> -------------------------------------------------------
>
> Key: SHINDIG-1485
> URL: https://issues.apache.org/jira/browse/SHINDIG-1485
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.3, 3.0.0
> Environment: All
> Reporter: Mark Weitzel
> Priority: Minor
> Fix For: 2.0.3, 3.0.0
>
> Attachments: embedTagUrl.patch
>
>
> Relative URLs in embed tags are not properly rewritten.
> This was discovered when trying to work with an .swf file.An embed tag's relative URL is not being properly rewritten. However, as a test, if you simply changed the tag to be an img, the it worked.
> I'll attach a patch that should fix this problem by adding embed to AbsolutePathReferenceVisitor
> The discussion thread on shidig dev is here:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201101.mbox/ajax/%3CC94BD537.3D65%mark.weitzel@jivesoftware.com%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1485) Relative URLs in embed tags are not
properly rewritten.
Posted by "Mark Weitzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Weitzel updated SHINDIG-1485:
----------------------------------
Attachment: embedTagUrl.patch
Adds the following to AbsolutePathReference
public enum Tags {
// Resources which would be fetched by the browser when rendering the page.
//TODO: Document the second parameter for clarity
// Does it make sense to factor this out into shindig properties?
RESOURCES(ImmutableMap.<String, String>builder()
.put("body", "background")
.put("img", "src")
.put("input", "src")
.put("link", "href")
.put("embed", "src")
.put("script", "src").build()),
> Relative URLs in embed tags are not properly rewritten.
> -------------------------------------------------------
>
> Key: SHINDIG-1485
> URL: https://issues.apache.org/jira/browse/SHINDIG-1485
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.0.3, 3.0.0
> Environment: All
> Reporter: Mark Weitzel
> Priority: Minor
> Fix For: 2.0.3, 3.0.0
>
> Attachments: embedTagUrl.patch
>
>
> Relative URLs in embed tags are not properly rewritten.
> This was discovered when trying to work with an .swf file.An embed tag's relative URL is not being properly rewritten. However, as a test, if you simply changed the tag to be an img, the it worked.
> I'll attach a patch that should fix this problem by adding embed to AbsolutePathReferenceVisitor
> The discussion thread on shidig dev is here:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201101.mbox/ajax/%3CC94BD537.3D65%mark.weitzel@jivesoftware.com%3E
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.