You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/24 11:03:30 UTC
[GitHub] [hudi] Aiden-Dong opened a new pull request, #5963: [HUDI-4300] Add sync clean and archive for compaction service in Spark Env
Aiden-Dong opened a new pull request, #5963:
URL: https://github.com/apache/hudi/pull/5963
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5963: [HUDI-4300] Add sync clean and archive for compaction service in Spark Env
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5963:
URL: https://github.com/apache/hudi/pull/5963#issuecomment-1165495799
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea55c2008200697bf511573af531b38b125444d1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9511",
"triggerID" : "ea55c2008200697bf511573af531b38b125444d1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea55c2008200697bf511573af531b38b125444d1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9511)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Aiden-Dong commented on pull request #5963: [HUDI-4300] Add sync clean and archive for compaction service in Spark Env
Posted by GitBox <gi...@apache.org>.
Aiden-Dong commented on PR #5963:
URL: https://github.com/apache/hudi/pull/5963#issuecomment-1175746885
@danny0405 Hello, can you take a moment to check this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5963: [HUDI-4300] Add sync clean and archive for compaction service in Spark Env
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5963:
URL: https://github.com/apache/hudi/pull/5963#issuecomment-1165941478
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea55c2008200697bf511573af531b38b125444d1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9511",
"triggerID" : "ea55c2008200697bf511573af531b38b125444d1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea55c2008200697bf511573af531b38b125444d1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9511)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5963: [HUDI-4300] Add sync clean and archive for compaction service in Spark Env
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5963:
URL: https://github.com/apache/hudi/pull/5963#issuecomment-1165492725
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea55c2008200697bf511573af531b38b125444d1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ea55c2008200697bf511573af531b38b125444d1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea55c2008200697bf511573af531b38b125444d1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #5963: [HUDI-4300] Add sync clean and archive for compaction service in Spark Env
Posted by GitBox <gi...@apache.org>.
yihua commented on PR #5963:
URL: https://github.com/apache/hudi/pull/5963#issuecomment-1245002913
Closing this PR as the change is an anti-pattern. @Aiden-Dong Feel free to reopen if you do have a special use case. If you do want to trigger cleaning and archive, it should be in a separate table service job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua closed pull request #5963: [HUDI-4300] Add sync clean and archive for compaction service in Spark Env
Posted by GitBox <gi...@apache.org>.
yihua closed pull request #5963: [HUDI-4300] Add sync clean and archive for compaction service in Spark Env
URL: https://github.com/apache/hudi/pull/5963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #5963: [HUDI-4300] Add sync clean and archive for compaction service in Spark Env
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #5963:
URL: https://github.com/apache/hudi/pull/5963#discussion_r969033853
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java:
##########
@@ -326,6 +326,8 @@ protected void completeCompaction(HoodieCommitMetadata metadata,
+ config.getBasePath() + " at time " + compactionCommitTime, e);
}
}
+ autoCleanOnCommit();
+ autoArchiveOnCommit(table, true);
Review Comment:
One table service should not trigger other table services. Table services should only be triggered by one regular writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org