You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2025/04/02 20:48:31 UTC

[PR] Update illustration for cut_release_branch workflow [beam]

Abacn opened a new pull request, #34526:
URL: https://github.com/apache/beam/pull/34526

   Follow up of #34522
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update illustration for cut_release_branch workflow [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #34526:
URL: https://github.com/apache/beam/pull/34526#issuecomment-2795207282

   R: @damccorm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update illustration for cut_release_branch workflow [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #34526:
URL: https://github.com/apache/beam/pull/34526#issuecomment-2797381643

   > I think this is actually not right. When we create the tag, we create a separate commit which is not on any branch, so it shouldn't point to a commit on the master branch
   
   It is not a "lightweight" tag (not "annotated" tag) so it won't create a commit. It points to a commit on the master branch (the commit write before bumping version number)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update illustration for cut_release_branch workflow [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #34526:
URL: https://github.com/apache/beam/pull/34526#issuecomment-2794228977

   assign to next reviewer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update illustration for cut_release_branch workflow [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34526:
URL: https://github.com/apache/beam/pull/34526#issuecomment-2792543334

   Reminder, please take a look at this pr: @kennknowles 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update illustration for cut_release_branch workflow [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34526:
URL: https://github.com/apache/beam/pull/34526#issuecomment-2795209813

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update illustration for cut_release_branch workflow [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #34526:
URL: https://github.com/apache/beam/pull/34526


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update illustration for cut_release_branch workflow [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #34526:
URL: https://github.com/apache/beam/pull/34526#issuecomment-2797539324

   > > I think this is actually not right. When we create the tag, we create a separate commit which is not on any branch, so it shouldn't point to a commit on the master branch
   > 
   > It is a "lightweight" tag (not "annotated" tag) so it won't create a commit. It points to a commit on the master branch (the commit write before bumping version number)
   > 
   > checked git log on master contains the following commits:
   > 
   > ```
   > commit a5281ddec07cbb468bfc3b656f2ee0e7652fe799
   > Author: Danny McCormick <da...@google.com>
   > Date:   Fri Mar 21 11:07:11 2025 -0400
   > 
   >     Perform correct release version validation (#34378)
   > 
   > commit 76dfe7807c13b8f30029310cab25cc64bd683947
   > Author: liferoad <actions@GitHub Actions 312.local>
   > Date:   Fri Mar 21 13:20:40 2025 +0000
   > 
   >     Moving to 2.65.0-SNAPSHOT on master branch.
   > 
   > commit 24c230510be8b5e400021e8325ea654481c13698 (tag: v2.64.0-RC00)
   > Author: liferoad <hu...@gmail.com>
   > Date:   Fri Mar 21 09:16:23 2025 -0400
   > 
   >     Fix version on the master (#34371)
   >     
   >     * fix the check
   >     
   >     * minor fix
   > ```
   
   Oh, I see - I was thinking about https://github.com/apache/beam/tree/v2.64.0-RC1, not https://github.com/apache/beam/tree/v2.64.0-RC00
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update illustration for cut_release_branch workflow [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34526:
URL: https://github.com/apache/beam/pull/34526#issuecomment-2773793571

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @kennknowles added as fallback since no labels match configuration
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org