[jira] [Comment Edited] (YETUS-1229) Yetus falsely reports on ASF licence after removing files from the PR

["Allen Wittenauer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726270#comment-17726270 ] 

Allen Wittenauer edited comment on YETUS-1229 at 5/25/23 3:09 PM:
------------------------------------------------------------------

In the vast majority of cases like this one, rebasing+squashing the commits is generally required because the patch being generated by github is leaving these files hanging around. 


was (Author: aw):
In the vast majority of cases like this one, rebasing+squashing the commits is generally required because the patch being generated is leaving these files hanging around. 

> Yetus falsely reports on ASF licence after removing files from the PR
> ---------------------------------------------------------------------
>
>                 Key: YETUS-1229
>                 URL: https://issues.apache.org/jira/browse/YETUS-1229
>             Project: Yetus
>          Issue Type: Bug
>          Components: github-action
>            Reporter: Ferenc Erdelyi
>            Priority: Major
>         Attachments: Yetus_20Report.zip
>
>
> For [PR-56638|[https://github.com/apache/hadoop/pull/5638]] I've added text-based certificate files for testing, which did not have ASF license. Later on, I removed these text-based certificates (as these were not used) and kept the binary truststore and keystore files only.
> The expected behavior was that the ASF license check should pass.
> However, the check still alerted the already deleted files and Yetus failed the check.
> [https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5638/22/]
> [https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5638/22/Yetus_20Report/]
> h4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)