You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/04/24 18:14:52 UTC
[GitHub] [activemq-artemis] waldi5001 opened a new pull request, #4044: ARTEMIS-3707 ResourceAdapter Documentation
waldi5001 opened a new pull request, #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044
Documentation of the Artemis ResourceAdapter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4044: ARTEMIS-3707 ResourceAdapter Documentation
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044#issuecomment-1108891807
@gemmellr , @waldi5001 I only made a connection with the previous PR after I merged it. I can revert it and a new PR sent by @waldi5001 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #4044: ARTEMIS-3707 ResourceAdapter Documentation
Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044#issuecomment-1109753272
> @gemmellr It is no problem for me to fix the documentation afterwards and open a PR for that. At the moment no WLP sample is mentioned in the documentation, only available material is used...
Right, and I was saying that seems bizarre, if the original goal was actually to add new rars and get rid of the examples just documented.
>
> Have you found a solution to refer the version in the link?
>
I suggested on the original PR you could probably look to include it using some filtering.
I have just raised a PR making it available, #4050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #4044: ARTEMIS-3707 ResourceAdapter Documentation
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged PR #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4044: ARTEMIS-3707 ResourceAdapter Documentation
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044#issuecomment-1108964957
@waldi5001 , @gemmellr I reverted this commit as discussed, please send a new PR as we discussed earlier.
thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] waldi5001 commented on pull request #4044: ARTEMIS-3707 ResourceAdapter Documentation
Posted by GitBox <gi...@apache.org>.
waldi5001 commented on PR #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044#issuecomment-1108896594
No problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #4044: ARTEMIS-3707 ResourceAdapter Documentation
Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044#issuecomment-1108521451
I dont think this should have been merged with all the links to main in it (see outstanding feedback on the original PR).
I also dont think this one should have been raised at all when considering it is documenting the opposite approach of what the original PR was eventually described as being aimed at achieving (not having to build your own / use the described examples).
Oh well, I give up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] waldi5001 commented on pull request #4044: ARTEMIS-3707 ResourceAdapter Documentation
Posted by GitBox <gi...@apache.org>.
waldi5001 commented on PR #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044#issuecomment-1114195309
I opened the new PR #4060 with the version in the links. On my machine with `mvn clean install -Prelease -DskipTests` it works well.
> Right, and I was saying that seems bizarre, if the original goal was actually to add new rars and get rid of the examples just documented.
as I understood you, shipping a artemis.rar is not what you (or the team) want. So, in the documentation is explained what the readers have to do, if they want to use a resource adapter. No example get rid, no artemis.rar is added.
If I misunderstood you, no problem, I will open another PR with artemis.rar files, rid of the examples (or not) and a adjusted documentation.
But first of all #4043 have to be merged, without that it will become difficult to use the exampleArtemis.rar in the application server of your choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #4044: ARTEMIS-3707 ResourceAdapter Documentation
Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044#issuecomment-1115990630
You have definitely misunderstood me. Though I did query at one point why the new rar modules were being added, as they seemed largely duplication of the example and their presence wasnt clear based on the documentation also being added that said you _must_ build your own like the example, we then discussed why on the PR. I reviewed the PR multiple times after without saying 'remove these', and even added stuff to the build myself so you could use it to more easily action some prior feedback I had given, plus when you asked if the PR was dead I said no. You then closed it and raised the other of somewhat different PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #4044: ARTEMIS-3707 ResourceAdapter Documentation
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on PR #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044#issuecomment-1108502051
thanks for your contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] waldi5001 commented on pull request #4044: ARTEMIS-3707 ResourceAdapter Documentation
Posted by GitBox <gi...@apache.org>.
waldi5001 commented on PR #4044:
URL: https://github.com/apache/activemq-artemis/pull/4044#issuecomment-1108870899
@gemmellr It is no problem for me to fix the documentation afterwards and open a PR for that. At the moment no WLP sample is mentioned in the documentation, only available material is used...
Have you found a solution to refer the version in the link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org