You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/04/11 00:58:54 UTC
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/
-----------------------------------------------------------
(Updated April 10, 2014, 3:58 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased to master
Bugs: MESOS-1133
https://issues.apache.org/jira/browse/MESOS-1133
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/slave/slave.hpp 08f6005f57e6b74b657496da1d245531c1614594
src/slave/slave.cpp cddb241f12f3ca19d3ab3069b6d8399c2e3ea9bd
Diff: https://reviews.apache.org/r/19499/diff/
Testing (updated)
-------
make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
Thanks,
Dominic Hamon
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/#review42556
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19499]
All tests passed.
- Mesos ReviewBot
On May 9, 2014, 12:58 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19499/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 12:58 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1133
> https://issues.apache.org/jira/browse/MESOS-1133
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5
> src/slave/slave.cpp ba4bd731bc21cdf853c3d390296252ad4d0901cb
> src/tests/slave_tests.cpp 6526952528aaf69d77007b37cf96541162290c33
>
> Diff: https://reviews.apache.org/r/19499/diff/
>
>
> Testing
> -------
>
> make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/#review42593
-----------------------------------------------------------
Ship it!
Will get this committed! I'll clean up the test a bit and re-order the metrics a bit per my comment below.
src/slave/slave.hpp
<https://reviews.apache.org/r/19499/#comment76407>
How about we re-order these a bit by how "fundamental" these are:
process::metrics::Gauge uptime_secs;
process::metrics::Gauge registered;
process::metrics::Counter recovery_errors;
process::metrics::Gauge active_frameworks;
// TODO(dhamon): Add tasks Gauges.
process::metrics::Counter valid_status_updates;
process::metrics::Counter invalid_status_updates;
process::metrics::Counter valid_framework_messages;
process::metrics::Counter invalid_framework_messages;
src/tests/slave_tests.cpp
<https://reviews.apache.org/r/19499/#comment76409>
We can remove these.
- Ben Mahler
On May 9, 2014, 5:16 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19499/
> -----------------------------------------------------------
>
> (Updated May 9, 2014, 5:16 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1133 and MESOS-1332
> https://issues.apache.org/jira/browse/MESOS-1133
> https://issues.apache.org/jira/browse/MESOS-1332
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5
> src/slave/slave.cpp ba4bd731bc21cdf853c3d390296252ad4d0901cb
> src/tests/slave_tests.cpp 6526952528aaf69d77007b37cf96541162290c33
>
> Diff: https://reviews.apache.org/r/19499/diff/
>
>
> Testing
> -------
>
> make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/
-----------------------------------------------------------
(Updated May 9, 2014, 10:16 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
updated per MESOS-1332.
Bugs: MESOS-1133 and MESOS-1332
https://issues.apache.org/jira/browse/MESOS-1133
https://issues.apache.org/jira/browse/MESOS-1332
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5
src/slave/slave.cpp ba4bd731bc21cdf853c3d390296252ad4d0901cb
src/tests/slave_tests.cpp 6526952528aaf69d77007b37cf96541162290c33
Diff: https://reviews.apache.org/r/19499/diff/
Testing
-------
make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
Thanks,
Dominic Hamon
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/
-----------------------------------------------------------
(Updated May 8, 2014, 5:58 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
removed tasks counters as it's likely they should become gauges (MESOS-1332)
Bugs: MESOS-1133
https://issues.apache.org/jira/browse/MESOS-1133
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5
src/slave/slave.cpp ba4bd731bc21cdf853c3d390296252ad4d0901cb
src/tests/slave_tests.cpp 6526952528aaf69d77007b37cf96541162290c33
Diff: https://reviews.apache.org/r/19499/diff/
Testing
-------
make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
Thanks,
Dominic Hamon
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/
-----------------------------------------------------------
(Updated May 8, 2014, 11:47 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
added test to ensure stats are present as expected.
Bugs: MESOS-1133
https://issues.apache.org/jira/browse/MESOS-1133
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5
src/slave/slave.cpp 2a48266510a600349692780ea39cc98c3e12da30
src/tests/slave_tests.cpp 09824550101577f8c9cf65c18e4980b74494a7d7
Diff: https://reviews.apache.org/r/19499/diff/
Testing
-------
make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
Thanks,
Dominic Hamon
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On May 8, 2014, 11:13 a.m., Ben Mahler wrote:
> > src/slave/slave.cpp, lines 3087-3107
> > <https://reviews.apache.org/r/19499/diff/9/?file=573410#file573410line3087>
> >
> > Why are these separate from the other Gauge methods, can they go in the header for now? We could move them all to slave/metrics.cpp in the future.
as with the master, these require Framework and Executor to be complete types. We can either move them to the header and change the order of class definitions in the header, or have them here. Here is less disruptive.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/#review42520
-----------------------------------------------------------
On May 8, 2014, 11:47 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19499/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 11:47 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1133
> https://issues.apache.org/jira/browse/MESOS-1133
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5
> src/slave/slave.cpp 2a48266510a600349692780ea39cc98c3e12da30
> src/tests/slave_tests.cpp 09824550101577f8c9cf65c18e4980b74494a7d7
>
> Diff: https://reviews.apache.org/r/19499/diff/
>
>
> Testing
> -------
>
> make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/#review42520
-----------------------------------------------------------
Could we add a test like we did for the Master? (MasterTest.MetricsInStatsEndpoint).
How about we have a TODO to have slave/metrics.cpp where we can define all this stuff? :)
src/slave/slave.cpp
<https://reviews.apache.org/r/19499/#comment76309>
Why are these separate from the other Gauge methods, can they go in the header for now? We could move them all to slave/metrics.cpp in the future.
src/slave/slave.cpp
<https://reviews.apache.org/r/19499/#comment76310>
Can we remove the list logic here since we're not using it yet?
Ditto for the destructor.
- Ben Mahler
On May 2, 2014, 2:19 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19499/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 2:19 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1133
> https://issues.apache.org/jira/browse/MESOS-1133
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5
> src/slave/slave.cpp cb80609ba421b3b9a4664e600f0e53ecab8574c4
>
> Diff: https://reviews.apache.org/r/19499/diff/
>
>
> Testing
> -------
>
> make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/
-----------------------------------------------------------
(Updated May 1, 2014, 7:19 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased and updated to match benm's comments on 19504
Bugs: MESOS-1133
https://issues.apache.org/jira/browse/MESOS-1133
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5
src/slave/slave.cpp cb80609ba421b3b9a4664e600f0e53ecab8574c4
Diff: https://reviews.apache.org/r/19499/diff/
Testing
-------
make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
Thanks,
Dominic Hamon
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/
-----------------------------------------------------------
(Updated April 30, 2014, 10:39 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased and moved metrics into struct.
Bugs: MESOS-1133
https://issues.apache.org/jira/browse/MESOS-1133
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5
src/slave/slave.cpp cb80609ba421b3b9a4664e600f0e53ecab8574c4
Diff: https://reviews.apache.org/r/19499/diff/
Testing
-------
make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
Thanks,
Dominic Hamon
Re: Review Request 19499: Ported slave statistics over to new metrics
library.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/#review40136
-----------------------------------------------------------
Bad patch!
Reviews applied: [19499]
Failed command: make check
Error:
Making check in .
make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make[1]: Nothing to be done for `check-am'.
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
Making check in 3rdparty
make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make check-recursive
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
Making check in libprocess
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
Making check in 3rdparty
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make check-recursive
make[5]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
Making check in stout
make[6]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[6]: Nothing to be done for `check'.
make[6]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[6]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make libgmock.la stout-tests
make[7]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[7]: `libgmock.la' is up to date.
make[7]: `stout-tests' is up to date.
make[7]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make check-local
make[7]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
./stout-tests
[==========] Running 121 tests from 24 test cases.
[----------] Global test environment set-up.
[----------] 3 tests from Stout
[ RUN ] Stout.Bytes
[ OK ] Stout.Bytes (0 ms)
[ RUN ] Stout.Set
[ OK ] Stout.Set (20 ms)
[ RUN ] Stout.Some
[ OK ] Stout.Some (11 ms)
[----------] 3 tests from Stout (31 ms total)
[----------] 4 tests from Cache
[ RUN ] Cache.Insert
[ OK ] Cache.Insert (0 ms)
[ RUN ] Cache.Update
[ OK ] Cache.Update (0 ms)
[ RUN ] Cache.Erase
[ OK ] Cache.Erase (0 ms)
[ RUN ] Cache.LRUEviction
[ OK ] Cache.LRUEviction (0 ms)
[----------] 4 tests from Cache (0 ms total)
[----------] 4 tests from DurationTest
[ RUN ] DurationTest.Comparison
[ OK ] DurationTest.Comparison (0 ms)
[ RUN ] DurationTest.ParseAndTry
[ OK ] DurationTest.ParseAndTry (8 ms)
[ RUN ] DurationTest.Arithmetic
[ OK ] DurationTest.Arithmetic (0 ms)
[ RUN ] DurationTest.OutputFormat
[ OK ] DurationTest.OutputFormat (4 ms)
[----------] 4 tests from DurationTest (13 ms total)
[----------] 1 test from ErrorTest
[ RUN ] ErrorTest.Test
[ OK ] ErrorTest.Test (0 ms)
[----------] 1 test from ErrorTest (0 ms total)
[----------] 12 tests from FlagsTest
[ RUN ] FlagsTest.Load
[ OK ] FlagsTest.Load (1 ms)
[ RUN ] FlagsTest.Add
[ OK ] FlagsTest.Add (0 ms)
[ RUN ] FlagsTest.Flags
[ OK ] FlagsTest.Flags (0 ms)
[ RUN ] FlagsTest.LoadFromEnvironment
[ OK ] FlagsTest.LoadFromEnvironment (0 ms)
[ RUN ] FlagsTest.LoadFromCommandLine
[ OK ] FlagsTest.LoadFromCommandLine (0 ms)
[ RUN ] FlagsTest.LoadFromCommandLineWithNonFlags
[ OK ] FlagsTest.LoadFromCommandLineWithNonFlags (0 ms)
[ RUN ] FlagsTest.Stringification
[ OK ] FlagsTest.Stringification (0 ms)
[ RUN ] FlagsTest.DuplicatesFromEnvironment
[ OK ] FlagsTest.DuplicatesFromEnvironment (0 ms)
[ RUN ] FlagsTest.DuplicatesFromCommandLine
[ OK ] FlagsTest.DuplicatesFromCommandLine (0 ms)
[ RUN ] FlagsTest.Errors
[ OK ] FlagsTest.Errors (0 ms)
[ RUN ] FlagsTest.Usage
[ OK ] FlagsTest.Usage (0 ms)
[ RUN ] FlagsTest.Duration
[ OK ] FlagsTest.Duration (0 ms)
[----------] 12 tests from FlagsTest (1 ms total)
[----------] 1 test from GzipTest
[ RUN ] GzipTest.CompressDecompressString
[ OK ] GzipTest.CompressDecompressString (120 ms)
[----------] 1 test from GzipTest (120 ms total)
[----------] 2 tests from HashMapTest
[ RUN ] HashMapTest.Insert
[ OK ] HashMapTest.Insert (0 ms)
[ RUN ] HashMapTest.Contains
[ OK ] HashMapTest.Contains (0 ms)
[----------] 2 tests from HashMapTest (0 ms total)
[----------] 2 tests from HashsetTest
[ RUN ] HashsetTest.Insert
[ OK ] HashsetTest.Insert (7 ms)
[ RUN ] HashsetTest.Union
[ OK ] HashsetTest.Union (0 ms)
[----------] 2 tests from HashsetTest (7 ms total)
[----------] 8 tests from IntervalTest
[ RUN ] IntervalTest.Interval
[ OK ] IntervalTest.Interval (0 ms)
[ RUN ] IntervalTest.EmptyInterval
[ OK ] IntervalTest.EmptyInterval (0 ms)
[ RUN ] IntervalTest.Constructor
[ OK ] IntervalTest.Constructor (0 ms)
[ RUN ] IntervalTest.Addition
[ OK ] IntervalTest.Addition (0 ms)
[ RUN ] IntervalTest.Subtraction
[ OK ] IntervalTest.Subtraction (0 ms)
[ RUN ] IntervalTest.Intersection
[ OK ] IntervalTest.Intersection (0 ms)
[ RUN ] IntervalTest.LargeInterval
[ OK ] IntervalTest.LargeInterval (0 ms)
[ RUN ] IntervalTest.IntervalIteration
[ OK ] IntervalTest.IntervalIteration (0 ms)
[----------] 8 tests from IntervalTest (0 ms total)
[----------] 8 tests from JsonTest
[ RUN ] JsonTest.DefaultValueIsNull
[ OK ] JsonTest.DefaultValueIsNull (0 ms)
[ RUN ] JsonTest.BinaryData
[ OK ] JsonTest.BinaryData (0 ms)
[ RUN ] JsonTest.NumberFormat
[ OK ] JsonTest.NumberFormat (0 ms)
[ RUN ] JsonTest.BooleanFormat
[ OK ] JsonTest.BooleanFormat (0 ms)
[ RUN ] JsonTest.BooleanAssignement
[ OK ] JsonTest.BooleanAssignement (0 ms)
[ RUN ] JsonTest.CStringAssignment
[ OK ] JsonTest.CStringAssignment (0 ms)
[ RUN ] JsonTest.NumericAssignment
[ OK ] JsonTest.NumericAssignment (0 ms)
[ RUN ] JsonTest.parse
[ OK ] JsonTest.parse (0 ms)
[----------] 8 tests from JsonTest (1 ms total)
[----------] 5 tests from LinkedHashmapTest
[ RUN ] LinkedHashmapTest.Put
[ OK ] LinkedHashmapTest.Put (0 ms)
[ RUN ] LinkedHashmapTest.Contains
[ OK ] LinkedHashmapTest.Contains (0 ms)
[ RUN ] LinkedHashmapTest.Erase
[ OK ] LinkedHashmapTest.Erase (0 ms)
[ RUN ] LinkedHashmapTest.Keys
[ OK ] LinkedHashmapTest.Keys (0 ms)
[ RUN ] LinkedHashmapTest.Values
[ OK ] LinkedHashmapTest.Values (0 ms)
[----------] 5 tests from LinkedHashmapTest (0 ms total)
[----------] 6 tests from MultimapTest/0, where TypeParam = Multimap<std::string, unsigned short>
[ RUN ] MultimapTest/0.Put
[ OK ] MultimapTest/0.Put (0 ms)
[ RUN ] MultimapTest/0.Remove
[ OK ] MultimapTest/0.Remove (0 ms)
[ RUN ] MultimapTest/0.Size
[ OK ] MultimapTest/0.Size (0 ms)
[ RUN ] MultimapTest/0.Keys
[ OK ] MultimapTest/0.Keys (0 ms)
[ RUN ] MultimapTest/0.Iterator
[ OK ] MultimapTest/0.Iterator (0 ms)
[ RUN ] MultimapTest/0.Foreach
[ OK ] MultimapTest/0.Foreach (0 ms)
[----------] 6 tests from MultimapTest/0 (0 ms total)
[----------] 6 tests from MultimapTest/1, where TypeParam = multihashmap<std::string, unsigned short>
[ RUN ] MultimapTest/1.Put
[ OK ] MultimapTest/1.Put (0 ms)
[ RUN ] MultimapTest/1.Remove
[ OK ] MultimapTest/1.Remove (0 ms)
[ RUN ] MultimapTest/1.Size
[ OK ] MultimapTest/1.Size (0 ms)
[ RUN ] MultimapTest/1.Keys
[ OK ] MultimapTest/1.Keys (0 ms)
[ RUN ] MultimapTest/1.Iterator
[ OK ] MultimapTest/1.Iterator (0 ms)
[ RUN ] MultimapTest/1.Foreach
[ OK ] MultimapTest/1.Foreach (0 ms)
[----------] 6 tests from MultimapTest/1 (0 ms total)
[----------] 4 tests from NetTest
[ RUN ] NetTest.mac
[ OK ] NetTest.mac (1 ms)
[ RUN ] NetTest.ConstructMAC
[ OK ] NetTest.ConstructMAC (0 ms)
[ RUN ] NetTest.ip
[ OK ] NetTest.ip (0 ms)
[ RUN ] NetTest.ConstructIP
[ OK ] NetTest.ConstructIP (0 ms)
[----------] 4 tests from NetTest (1 ms total)
[----------] 1 test from NoneTest
[ RUN ] NoneTest.Test
[ OK ] NoneTest.Test (0 ms)
[----------] 1 test from NoneTest (0 ms total)
[----------] 3 tests from OptionTest
[ RUN ] OptionTest.Min
[ OK ] OptionTest.Min (0 ms)
[ RUN ] OptionTest.Max
[ OK ] OptionTest.Max (0 ms)
[ RUN ] OptionTest.Comparison
[ OK ] OptionTest.Comparison (0 ms)
[----------] 3 tests from OptionTest (0 ms total)
[----------] 18 tests from OsTest
[ RUN ] OsTest.environment
[ OK ] OsTest.environment (25 ms)
[ RUN ] OsTest.rmdir
[ OK ] OsTest.rmdir (14 ms)
[ RUN ] OsTest.system
sh: 1: invalid.command: not found
[ OK ] OsTest.system (54 ms)
[ RUN ] OsTest.nonblock
[ OK ] OsTest.nonblock (0 ms)
[ RUN ] OsTest.touch
[ OK ] OsTest.touch (15 ms)
[ RUN ] OsTest.readWriteString
[ OK ] OsTest.readWriteString (15 ms)
[ RUN ] OsTest.find
[ OK ] OsTest.find (18 ms)
[ RUN ] OsTest.bootId
[ OK ] OsTest.bootId (0 ms)
[ RUN ] OsTest.uname
[ OK ] OsTest.uname (0 ms)
[ RUN ] OsTest.sysname
[ OK ] OsTest.sysname (16 ms)
[ RUN ] OsTest.release
[ OK ] OsTest.release (0 ms)
[ RUN ] OsTest.sleep
[ OK ] OsTest.sleep (15 ms)
[ RUN ] OsTest.pids
[ OK ] OsTest.pids (155 ms)
[ RUN ] OsTest.children
[ OK ] OsTest.children (43 ms)
[ RUN ] OsTest.process
[ OK ] OsTest.process (0 ms)
[ RUN ] OsTest.processes
[ OK ] OsTest.processes (14 ms)
[ RUN ] OsTest.killtree
[ OK ] OsTest.killtree (82 ms)
[ RUN ] OsTest.pstree
[ OK ] OsTest.pstree (44 ms)
[----------] 18 tests from OsTest (510 ms total)
[----------] 1 test from ProtobufTest
[ RUN ] ProtobufTest.JSON
[ OK ] ProtobufTest.JSON (5 ms)
[----------] 1 test from ProtobufTest (5 ms total)
[----------] 1 test from OsSendfileTest
[ RUN ] OsSendfileTest.sendfile
[ OK ] OsSendfileTest.sendfile (6 ms)
[----------] 1 test from OsSendfileTest (6 ms total)
[----------] 1 test from OsSignalsTest
[ RUN ] OsSignalsTest.suppress
[ OK ] OsSignalsTest.suppress (0 ms)
[----------] 1 test from OsSignalsTest (0 ms total)
[----------] 22 tests from StringsTest
[ RUN ] StringsTest.Format
[ OK ] StringsTest.Format (0 ms)
[ RUN ] StringsTest.Remove
[ OK ] StringsTest.Remove (0 ms)
[ RUN ] StringsTest.Replace
[ OK ] StringsTest.Replace (0 ms)
[ RUN ] StringsTest.Trim
[ OK ] StringsTest.Trim (0 ms)
[ RUN ] StringsTest.Tokenize
[ OK ] StringsTest.Tokenize (0 ms)
[ RUN ] StringsTest.TokenizeStringWithDelimsAtStart
[ OK ] StringsTest.TokenizeStringWithDelimsAtStart (0 ms)
[ RUN ] StringsTest.TokenizeStringWithDelimsAtEnd
[ OK ] StringsTest.TokenizeStringWithDelimsAtEnd (0 ms)
[ RUN ] StringsTest.TokenizeStringWithDelimsAtStartAndEnd
[ OK ] StringsTest.TokenizeStringWithDelimsAtStartAndEnd (0 ms)
[ RUN ] StringsTest.TokenizeWithMultipleDelims
[ OK ] StringsTest.TokenizeWithMultipleDelims (0 ms)
[ RUN ] StringsTest.TokenizeEmptyString
[ OK ] StringsTest.TokenizeEmptyString (0 ms)
[ RUN ] StringsTest.TokenizeDelimOnlyString
[ OK ] StringsTest.TokenizeDelimOnlyString (0 ms)
[ RUN ] StringsTest.TokenizeNullByteDelim
[ OK ] StringsTest.TokenizeNullByteDelim (0 ms)
[ RUN ] StringsTest.SplitEmptyString
[ OK ] StringsTest.SplitEmptyString (0 ms)
[ RUN ] StringsTest.SplitDelimOnlyString
[ OK ] StringsTest.SplitDelimOnlyString (0 ms)
[ RUN ] StringsTest.Split
[ OK ] StringsTest.Split (0 ms)
[ RUN ] StringsTest.SplitStringWithDelimsAtStart
[ OK ] StringsTest.SplitStringWithDelimsAtStart (0 ms)
[ RUN ] StringsTest.SplitStringWithDelimsAtEnd
[ OK ] StringsTest.SplitStringWithDelimsAtEnd (0 ms)
[ RUN ] StringsTest.SplitStringWithDelimsAtStartAndEnd
[ OK ] StringsTest.SplitStringWithDelimsAtStartAndEnd (0 ms)
[ RUN ] StringsTest.SplitWithMultipleDelims
[ OK ] StringsTest.SplitWithMultipleDelims (0 ms)
[ RUN ] StringsTest.Pairs
[ OK ] StringsTest.Pairs (0 ms)
[ RUN ] StringsTest.StartsWith
[ OK ] StringsTest.StartsWith (0 ms)
[ RUN ] StringsTest.Contains
[ OK ] StringsTest.Contains (0 ms)
[----------] 22 tests from StringsTest (0 ms total)
[----------] 1 test from Thread
[ RUN ] Thread.local
[ OK ] Thread.local (0 ms)
[----------] 1 test from Thread (0 ms total)
[----------] 1 test from UUIDTest
[ RUN ] UUIDTest.test
[ OK ] UUIDTest.test (1 ms)
[----------] 1 test from UUIDTest (1 ms total)
[----------] 6 tests from ProcTest
[ RUN ] ProcTest.pids
[ OK ] ProcTest.pids (0 ms)
[ RUN ] ProcTest.cpus
[ OK ] ProcTest.cpus (1 ms)
[ RUN ] ProcTest.SystemStatus
[ OK ] ProcTest.SystemStatus (0 ms)
[ RUN ] ProcTest.ProcessStatus
[ OK ] ProcTest.ProcessStatus (0 ms)
[ RUN ] ProcTest.SingleThread
[ OK ] ProcTest.SingleThread (1 ms)
[ RUN ] ProcTest.MultipleThreads
[ OK ] ProcTest.MultipleThreads (2 ms)
[----------] 6 tests from ProcTest (4 ms total)
[----------] Global test environment tear-down
[==========] 121 tests from 24 test cases ran. (700 ms total)
[ PASSED ] 121 tests.
make[7]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[6]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[5]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
Making check in .
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make tests
make[5]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[5]: `tests' is up to date.
make[5]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make check-local
make[5]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
./tests
[==========] Running 93 tests from 16 test cases.
[----------] Global test environment set-up.
[----------] 3 tests from Decoder
[ RUN ] Decoder.Request
[ OK ] Decoder.Request (0 ms)
[ RUN ] Decoder.RequestHeaderContinuation
[ OK ] Decoder.RequestHeaderContinuation (0 ms)
[ RUN ] Decoder.Response
[ OK ] Decoder.Response (1 ms)
[----------] 3 tests from Decoder (2 ms total)
[----------] 2 tests from Encoder
[ RUN ] Encoder.Response
[ OK ] Encoder.Response (0 ms)
[ RUN ] Encoder.AcceptableEncodings
[ OK ] Encoder.AcceptableEncodings (1 ms)
[----------] 2 tests from Encoder (1 ms total)
[----------] 5 tests from HTTP
[ RUN ] HTTP.Endpoints
[ OK ] HTTP.Endpoints (61 ms)
[ RUN ] HTTP.Encode
[ OK ] HTTP.Encode (0 ms)
[ RUN ] HTTP.PathParse
[ OK ] HTTP.PathParse (0 ms)
[ RUN ] HTTP.Get
[ OK ] HTTP.Get (2 ms)
[ RUN ] HTTP.Post
[ OK ] HTTP.Post (0 ms)
[----------] 5 tests from HTTP (63 ms total)
[----------] 5 tests from IO
[ RUN ] IO.Poll
[ OK ] IO.Poll (0 ms)
[ RUN ] IO.Read
[ OK ] IO.Read (1 ms)
[ RUN ] IO.BufferedRead
[ OK ] IO.BufferedRead (14 ms)
[ RUN ] IO.Write
[ OK ] IO.Write (0 ms)
[ RUN ] IO.splice
[ OK ] IO.splice (49 ms)
[----------] 5 tests from IO (64 ms total)
[----------] 3 tests from Mutex
[ RUN ] Mutex.lock
[ OK ] Mutex.lock (0 ms)
[ RUN ] Mutex.block
[ OK ] Mutex.block (0 ms)
[ RUN ] Mutex.queue
[ OK ] Mutex.queue (0 ms)
[----------] 3 tests from Mutex (0 ms total)
[----------] 2 tests from MetricsTest
[ RUN ] MetricsTest.Counter
[ OK ] MetricsTest.Counter (9 ms)
[ RUN ] MetricsTest.Gauge
[ OK ] MetricsTest.Gauge (32 ms)
[----------] 2 tests from MetricsTest (41 ms total)
[----------] 3 tests from Owned
[ RUN ] Owned.Access
[ OK ] Owned.Access (0 ms)
[ RUN ] Owned.Null
[ OK ] Owned.Null (0 ms)
[ RUN ] Owned.Share
[ OK ] Owned.Share (4 ms)
[----------] 3 tests from Owned (4 ms total)
[----------] 39 tests from Process
[ RUN ] Process.event
[ OK ] Process.event (0 ms)
[ RUN ] Process.future
[ OK ] Process.future (0 ms)
[ RUN ] Process.associate
[ OK ] Process.associate (0 ms)
[ RUN ] Process.onAny
[ OK ] Process.onAny (0 ms)
[ RUN ] Process.then
[ OK ] Process.then (4 ms)
[ RUN ] Process.after1
[ OK ] Process.after1 (12 ms)
[ RUN ] Process.after2
[ OK ] Process.after2 (11 ms)
[ RUN ] Process.chain
[ OK ] Process.chain (0 ms)
[ RUN ] Process.discard1
[ OK ] Process.discard1 (1 ms)
[ RUN ] Process.discard2
[ OK ] Process.discard2 (0 ms)
[ RUN ] Process.discard3
[ OK ] Process.discard3 (0 ms)
[ RUN ] Process.spawn
[ OK ] Process.spawn (0 ms)
[ RUN ] Process.dispatch
[ OK ] Process.dispatch (1 ms)
[ RUN ] Process.defer1
[ OK ] Process.defer1 (3 ms)
[ RUN ] Process.defer2
[ OK ] Process.defer2 (1 ms)
[ RUN ] Process.defer3
[ OK ] Process.defer3 (0 ms)
[ RUN ] Process.handlers
[ OK ] Process.handlers (0 ms)
[ RUN ] Process.expect
[ OK ] Process.expect (8 ms)
[ RUN ] Process.action
[ OK ] Process.action (0 ms)
[ RUN ] Process.inheritance
[ OK ] Process.inheritance (0 ms)
[ RUN ] Process.thunk
[ OK ] Process.thunk (1 ms)
[ RUN ] Process.delegate
[ OK ] Process.delegate (0 ms)
[ RUN ] Process.delay
[ OK ] Process.delay (0 ms)
[ RUN ] Process.order
[ OK ] Process.order (0 ms)
[ RUN ] Process.donate
[ OK ] Process.donate (0 ms)
[ RUN ] Process.exited
[ OK ] Process.exited (0 ms)
[ RUN ] Process.select
[ OK ] Process.select (0 ms)
[ RUN ] Process.collect
[ OK ] Process.collect (0 ms)
[ RUN ] Process.await1
[ OK ] Process.await1 (0 ms)
[ RUN ] Process.await2
[ OK ] Process.await2 (0 ms)
[ RUN ] Process.await3
[ OK ] Process.await3 (1 ms)
[ RUN ] Process.settle
[ OK ] Process.settle (40 ms)
[ RUN ] Process.pid
[ OK ] Process.pid (0 ms)
[ RUN ] Process.listener
[ OK ] Process.listener (0 ms)
[ RUN ] Process.executor
[ OK ] Process.executor (4 ms)
[ RUN ] Process.remote
[ OK ] Process.remote (1 ms)
[ RUN ] Process.async
[ OK ] Process.async (1 ms)
[ RUN ] Process.limiter
[ OK ] Process.limiter (6 ms)
[ RUN ] Process.provide
[ OK ] Process.provide (21 ms)
[----------] 39 tests from Process (117 ms total)
[----------] 1 test from Future
[ RUN ] Future.FromTry
[ OK ] Future.FromTry (0 ms)
[----------] 1 test from Future (0 ms total)
[----------] 3 tests from Reap
[ RUN ] Reap.NonChildProcess
[ OK ] Reap.NonChildProcess (48 ms)
[ RUN ] Reap.ChildProcess
[ OK ] Reap.ChildProcess (22 ms)
[ RUN ] Reap.TerminatedChildProcess
[ OK ] Reap.TerminatedChildProcess (23 ms)
[----------] 3 tests from Reap (93 ms total)
[----------] 4 tests from Sequence
[ RUN ] Sequence.Serialize
[ OK ] Sequence.Serialize (14 ms)
[ RUN ] Sequence.DiscardOne
[ OK ] Sequence.DiscardOne (16 ms)
[ RUN ] Sequence.DiscardAll
[ OK ] Sequence.DiscardAll (10 ms)
[ RUN ] Sequence.Random
[ OK ] Sequence.Random (12 ms)
[----------] 4 tests from Sequence (52 ms total)
[----------] 4 tests from Shared
[ RUN ] Shared.ConstAccess
[ OK ] Shared.ConstAccess (0 ms)
[ RUN ] Shared.Null
[ OK ] Shared.Null (0 ms)
[ RUN ] Shared.Reset
[ OK ] Shared.Reset (0 ms)
[ RUN ] Shared.Own
[ OK ] Shared.Own (0 ms)
[----------] 4 tests from Shared (0 ms total)
[----------] 3 tests from Statistics
[ RUN ] Statistics.set
[ OK ] Statistics.set (1 ms)
[ RUN ] Statistics.increment
[ OK ] Statistics.increment (1 ms)
[ RUN ] Statistics.decrement
[ OK ] Statistics.decrement (0 ms)
[----------] 3 tests from Statistics (3 ms total)
[----------] 10 tests from Subprocess
[ RUN ] Subprocess.status
[ OK ] Subprocess.status (123 ms)
[ RUN ] Subprocess.output
[ OK ] Subprocess.output (64 ms)
[ RUN ] Subprocess.input
[ OK ] Subprocess.input (31 ms)
[ RUN ] Subprocess.splice
[ OK ] Subprocess.splice (35 ms)
[ RUN ] Subprocess.environment
[ OK ] Subprocess.environment (63 ms)
[ RUN ] Subprocess.environmentWithSpaces
[ OK ] Subprocess.environmentWithSpaces (32 ms)
[ RUN ] Subprocess.environmentWithSpacesAndQuotes
[ OK ] Subprocess.environmentWithSpacesAndQuotes (32 ms)
[ RUN ] Subprocess.environmentOverride
[ OK ] Subprocess.environmentOverride (32 ms)
[ RUN ] Subprocess.setup
[ OK ] Subprocess.setup (38 ms)
[ RUN ] Subprocess.setupStatus
[ OK ] Subprocess.setupStatus (64 ms)
[----------] 10 tests from Subprocess (516 ms total)
[----------] 3 tests from TimeSeries
[ RUN ] TimeSeries.set
[ OK ] TimeSeries.set (0 ms)
[ RUN ] TimeSeries.sparsify
[ OK ] TimeSeries.sparsify (0 ms)
[ RUN ] TimeSeries.truncate
[ OK ] TimeSeries.truncate (0 ms)
[----------] 3 tests from TimeSeries (0 ms total)
[----------] 3 tests from TimeTest
[ RUN ] TimeTest.Arithmetic
[ OK ] TimeTest.Arithmetic (0 ms)
[ RUN ] TimeTest.Now
[ OK ] TimeTest.Now (0 ms)
[ RUN ] TimeTest.Output
[ OK ] TimeTest.Output (0 ms)
[----------] 3 tests from TimeTest (0 ms total)
[----------] Global test environment tear-down
[==========] 93 tests from 16 test cases ran. (956 ms total)
[ PASSED ] 93 tests.
YOU HAVE 2 DISABLED TESTS
make[5]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
cd leveldb && \
make CC="gcc" CXX="g++" OPT="-g -g2 -O2 -std=c++0x -fPIC"
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/leveldb'
make[4]: Nothing to be done for `default'.
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/leveldb'
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
Making check in src
make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make check-am
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make test-framework test-executor long-lived-framework long-lived-executor no-executor-framework balloon-framework balloon-executor mesos-tests examples/python/test_framework.py examples/python/test-framework examples/python/test_executor.py examples/python/test-executor \
tests/balloon_framework_test.sh tests/test_framework_test.sh tests/no_executor_framework_test.sh tests/java_exception_test.sh tests/java_framework_test.sh tests/java_log_test.sh tests/python_framework_test.sh
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[3]: `test-framework' is up to date.
make[3]: `test-executor' is up to date.
make[3]: `long-lived-framework' is up to date.
make[3]: `long-lived-executor' is up to date.
make[3]: `no-executor-framework' is up to date.
make[3]: `balloon-framework' is up to date.
make[3]: `balloon-executor' is up to date.
make[3]: `mesos-tests' is up to date.
make[3]: Nothing to be done for `examples/python/test_framework.py'.
make[3]: Nothing to be done for `examples/python/test-framework'.
make[3]: Nothing to be done for `examples/python/test_executor.py'.
make[3]: Nothing to be done for `examples/python/test-executor'.
make[3]: Nothing to be done for `tests/balloon_framework_test.sh'.
make[3]: Nothing to be done for `tests/test_framework_test.sh'.
make[3]: Nothing to be done for `tests/no_executor_framework_test.sh'.
make[3]: Nothing to be done for `tests/java_exception_test.sh'.
make[3]: Nothing to be done for `tests/java_framework_test.sh'.
make[3]: Nothing to be done for `tests/java_log_test.sh'.
make[3]: Nothing to be done for `tests/python_framework_test.sh'.
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make check-local
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
./mesos-tests
Source directory: /home/jenkins/jenkins-slave/workspace/mesos-reviewbot
Build directory: /home/jenkins/jenkins-slave/workspace/mesos-reviewbot
Note: Google Test filter = *-CpuIsolatorTest/1.UserCpuUsage:CpuIsolatorTest/1.SystemCpuUsage:LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs:LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota:MemIsolatorTest/0.MemUsage:MemIsolatorTest/1.MemUsage:ContainerizerTest.ROOT_CGROUPS_BalloonFramework:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Enabled:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Subsystems:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Mounted:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Get:CgroupsAnyHierarchyTest.ROOT_CGROUPS_NestedCgroups:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Tasks:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Read:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write:CgroupsAnyHierarchyTest.ROOT_CGROUPS_Cfs_Big_Quota:CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_Busy:CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_SubsystemsHierarchy:CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_MountedSubsystems:CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_CreateRemove:CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUP
S_Listen:CgroupsNoHierarchyTest.ROOT_CGROUPS_NOHIERARCHY_MountUnmountHierarchy:CgroupsAnyHierarchyWithCpuAcctMemoryTest.ROOT_CGROUPS_Stat:CgroupsAnyHierarchyWithFreezerTest.ROOT_CGROUPS_Freeze:CgroupsAnyHierarchyWithFreezerTest.ROOT_CGROUPS_Kill:CgroupsAnyHierarchyWithFreezerTest.ROOT_CGROUPS_Destroy:
[==========] Running 281 tests from 49 test cases.
[----------] Global test environment set-up.
[----------] 1 test from DRFAllocatorTest
[ RUN ] DRFAllocatorTest.DRFAllocatorProcess
[ OK ] DRFAllocatorTest.DRFAllocatorProcess (209 ms)
[----------] 1 test from DRFAllocatorTest (209 ms total)
[----------] 2 tests from ReservationAllocatorTest
[ RUN ] ReservationAllocatorTest.ReservedResources
[ OK ] ReservationAllocatorTest.ReservedResources (75 ms)
[ RUN ] ReservationAllocatorTest.ResourcesReturned
make[3]: *** [check-local] Segmentation fault
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On April 10, 2014, 10:58 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19499/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 10:58 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1133
> https://issues.apache.org/jira/browse/MESOS-1133
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 08f6005f57e6b74b657496da1d245531c1614594
> src/slave/slave.cpp cddb241f12f3ca19d3ab3069b6d8399c2e3ea9bd
>
> Diff: https://reviews.apache.org/r/19499/diff/
>
>
> Testing
> -------
>
> make check. ran locally and compared stats.json endpoint to /metrics/snapshot endpoint.
>
>
> Thanks,
>
> Dominic Hamon
>
>