You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/07/07 22:59:15 UTC
Review Request 36277: MESOS-3002: Fix getOrElse compilation error for
network isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36277/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-3002
https://issues.apache.org/jira/browse/MESOS-3002
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 2ef79eb9be76803d9a26223ee5763a582ca89736
Diff: https://reviews.apache.org/r/36277/diff/
Testing
-------
build with network isolator configured.
Thanks,
Joris Van Remoortere
Re: Review Request 36277: MESOS-3002: Fix getOrElse compilation error
for network isolator.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36277/#review90786
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 7, 2015, 8:59 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36277/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 8:59 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-3002
> https://issues.apache.org/jira/browse/MESOS-3002
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 2ef79eb9be76803d9a26223ee5763a582ca89736
>
> Diff: https://reviews.apache.org/r/36277/diff/
>
>
> Testing
> -------
>
> build with network isolator configured.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36277: MESOS-3002: Fix getOrElse compilation error
for network isolator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36277/#review90784
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36277]
All tests passed.
- Mesos ReviewBot
On July 7, 2015, 8:59 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36277/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 8:59 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-3002
> https://issues.apache.org/jira/browse/MESOS-3002
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 2ef79eb9be76803d9a26223ee5763a582ca89736
>
> Diff: https://reviews.apache.org/r/36277/diff/
>
>
> Testing
> -------
>
> build with network isolator configured.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36277: MESOS-3002: Fix getOrElse compilation error
for network isolator.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36277/#review90782
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On July 7, 2015, 1:59 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36277/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 1:59 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-3002
> https://issues.apache.org/jira/browse/MESOS-3002
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 2ef79eb9be76803d9a26223ee5763a582ca89736
>
> Diff: https://reviews.apache.org/r/36277/diff/
>
>
> Testing
> -------
>
> build with network isolator configured.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>