[jira] [Resolved] (OAK-6318) Refactor oak.spi.security into a separate module/bundle

["Alex Deparvu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Deparvu resolved OAK-6318.
-------------------------------
       Resolution: Fixed
    Fix Version/s: 1.7.9

fixed with http://svn.apache.org/viewvc?rev=1810297&view=rev

The biggest problem of this refactoring was the tree package. splitting it means we break backwards compatibility, which is something we don't want to do, so the solution was:
* copy the factories classes to a dedicated 'factories' package (in oak-core)
* mark the old factories as deprecated, and they will remain in the current location (oak-core) going forward until we can drop them in a future release
* move the remaining part of the tree package to the security-spi bundle

Because of this split, the tree package lives in 2 different bundles so the baseline plugin gets confused as it cannot merge it back for a complete view, so it thinks classes have been deleted, therefore I had to disable the baseline check for this package going forward.




> Refactor oak.spi.security into a separate module/bundle
> -------------------------------------------------------
>
>                 Key: OAK-6318
>                 URL: https://issues.apache.org/jira/browse/OAK-6318
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core, security
>            Reporter: angela
>            Assignee: angela
>             Fix For: 1.7.9
>
>         Attachments: PropInfo.patch
>
>
> In the light of the modularization effort it would IMHO make a lot of sense to refactor _oak.spi.security.*_ into a separate module/bundle that could be release independent of _oak-core_.
> As far as I could see so far this is currently not easily doable due to the dependency of {{oak.spi.security.*}} on {{oak.plugins.tree}}, which in turn relies on {{o.a.j.oak.query.QueryEngineSettings}} and other oak-core internals (see also OAK-6304). Most likely this issue would therefore require a complete review (and possibly a split) of  the {{oak.plugins.tree}} package space which contains a mixture of utilities and 'API' (like e.g. {{TreeContext}} and {{TreeLocation}})... will open a separate issue for this linking to this one.
> cc: [~stillalex], [~rombert], [~mduerig], [~tmueller]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)