You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Bill Farner <wf...@apache.org> on 2013/12/10 19:29:21 UTC
Re: Review Request 16054: Rewrite SchedulerLifecycle,
employing a state machine.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16054/#review30107
-----------------------------------------------------------
Ping? Seeking additional reviewers.
- Bill Farner
On Dec. 9, 2013, 8:11 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16054/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2013, 8:11 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This change addresses two issues:
> - Ensure leadership is canceled whenever onDefeated is called
> - Scheduler should wait for registered to be called before attempting to invoke driver
>
> Some additional structural changes were made:
> - Driver.run() is no longer used. Instead, we invoke Driver.start() (non-blocking), and the lifecycle uses Driver.join() to await exit.
> This allows us to avoid jumping through thread-safety hoops in unit tests.
> - A shim interface (DelayedActions) was added to SchedulerLifecycle to make testing easier when capturing delayed closures.
>
>
> Diffs
> -----
>
> src/main/java/com/twitter/aurora/scheduler/Driver.java e8fe170b2d9e1a752b152cedc0e006f10eaa5a11
> src/main/java/com/twitter/aurora/scheduler/ForwardingSchedulerDriver.java PRE-CREATION
> src/main/java/com/twitter/aurora/scheduler/SchedulerLifecycle.java 346d52acc5fc9e4841e2dc8b424fc6d46d2cdc8c
> src/main/java/com/twitter/aurora/scheduler/SchedulerModule.java bd7929d631cf45b4c2c7f39177bbafbd8f659071
> src/main/java/com/twitter/aurora/scheduler/app/SchedulerMain.java 73b86a9f99cb1931ccce1db0baf7c6f56ba0b65d
> src/main/java/com/twitter/aurora/scheduler/storage/testing/StorageTestUtil.java ceef9d3bd4b43d2dcac0ab9129ae2b624ab654cf
> src/test/java/com/twitter/aurora/scheduler/DriverTest.java 5609b0b8b9a26a737558316e8e4fab0235704cb8
> src/test/java/com/twitter/aurora/scheduler/SchedulerLifecycleTest.java PRE-CREATION
> src/test/java/com/twitter/aurora/scheduler/app/SchedulerIT.java 4c381b946c8a3c7bbe1757d384d5d43dd74bb4d0
>
> Diff: https://reviews.apache.org/r/16054/diff/
>
>
> Testing
> -------
>
> gradle clean build
>
>
> Thanks,
>
> Bill Farner
>
>