You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/09/30 16:04:00 UTC

[jira] [Updated] (ARROW-6744) Export JsonEqual trait in the array module

     [ https://issues.apache.org/jira/browse/ARROW-6744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated ARROW-6744:
----------------------------------
    Labels: easyfix pull-request-available  (was: easyfix)

> Export JsonEqual trait in the array module
> ------------------------------------------
>
>                 Key: ARROW-6744
>                 URL: https://issues.apache.org/jira/browse/ARROW-6744
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: Rust
>            Reporter: Kyle McCarthy
>            Priority: Trivial
>              Labels: easyfix, pull-request-available
>
> ARROW-5901 added checking for array equality with JSON arrays. This added the JsonEqual trait bound to the Array trait but it isn't exported making it private.
> The JsonEqual is a public trait, but the equal module is private and the JsonEqual trait isn't exported like the ArrayEqual trait.
> AFAIK this makes it impossible to implement your own arrays that are bound by the Array trait.
> I suggest that JsonEqual is exported with pub use like the ArrayEqual trait from the array module. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)