You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "lightzhao (via GitHub)" <gi...@apache.org> on 2023/03/09 11:00:19 UTC
[GitHub] [incubator-seatunnel] lightzhao opened a new pull request, #4318: [Improve][Connector-v2][JdbcSink]Fix max_retries default value.
lightzhao opened a new pull request, #4318:
URL: https://github.com/apache/incubator-seatunnel/pull/4318
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lightzhao commented on pull request #4318: [Improve][Connector-v2][JdbcSink]Fix max_retries default value.
Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on PR #4318:
URL: https://github.com/apache/incubator-seatunnel/pull/4318#issuecomment-1467244722
> Merge dev branch in your branch and try againe. Every pull reqeust before merged should pass all CI/CD.
Before submitted the pr, I already pulled the branch created by the latest code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #4318: [Improve][Connector-v2][JdbcSink]Fix max_retries default value.
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4318:
URL: https://github.com/apache/incubator-seatunnel/pull/4318#issuecomment-1477185299
>
@lightzhao You are right, you can submit another pr to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lightzhao commented on pull request #4318: [Improve][Connector-v2][JdbcSink]Fix max_retries default value.
Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on PR #4318:
URL: https://github.com/apache/incubator-seatunnel/pull/4318#issuecomment-1477686838
> >
>
> @lightzhao You are right, you can submit another pr to fix it
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lightzhao commented on pull request #4318: [Improve][Connector-v2][JdbcSink]Fix max_retries default value.
Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on PR #4318:
URL: https://github.com/apache/incubator-seatunnel/pull/4318#issuecomment-1473118826
@TyrantLucifer @Hisoka-X @ic4y @ashulin PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] lightzhao commented on pull request #4318: [Improve][Connector-v2][JdbcSink]Fix max_retries default value.
Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on PR #4318:
URL: https://github.com/apache/incubator-seatunnel/pull/4318#issuecomment-1477171763
> If the JDBC sink is IS_EXACTLY_ONCE, max_retries=0 is required, so the default value is 0.
>
> https://github.com/apache/incubator-seatunnel/blob/40699b660cfecb5cffb2da0a94dc1bbd29a19579/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcExactlyOnceSinkWriter.java#L77-L87
>
> You need to think about this.
The default value in the document is 3, the document is wrong, and the document needs to be modified.
<img width="619" alt="image" src="https://user-images.githubusercontent.com/40714172/226501118-433385fd-db62-46fb-a454-b515e5673840.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4318: [Improve][Connector-v2][JdbcSink]Fix max_retries default value.
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #4318:
URL: https://github.com/apache/incubator-seatunnel/pull/4318#issuecomment-1467233492
Merge dev branch in your branch and try againe. Every pull reqeust before merged should pass all CI/CD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #4318: [Improve][Connector-v2][JdbcSink]Fix max_retries default value.
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4318:
URL: https://github.com/apache/incubator-seatunnel/pull/4318#issuecomment-1476025057
If the JDBC sink is IS_EXACTLY_ONCE, max_retries=0 is required, so the default value is 0.
https://github.com/apache/incubator-seatunnel/blob/40699b660cfecb5cffb2da0a94dc1bbd29a19579/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcExactlyOnceSinkWriter.java#L77-L87
You need to think about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer closed pull request #4318: [Improve][Connector-v2][JdbcSink]Fix max_retries default value.
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #4318: [Improve][Connector-v2][JdbcSink]Fix max_retries default value.
URL: https://github.com/apache/incubator-seatunnel/pull/4318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org