You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/03/02 02:14:46 UTC
[GitHub] [guacamole-server] mike-jumper opened a new pull request #333: GUACAMOLE-1302: Add support for forcing lossless compression on VNC/RDP connections.
mike-jumper opened a new pull request #333:
URL: https://github.com/apache/guacamole-server/pull/333
This change adds a new `force-lossless` parameter to the VNC and RDP support, allowing the default lossy compression heuristics to be overridden. The default "use lossy compression if it looks appropriate" behavior of connections remains the same unless overridden with this new parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #333: GUACAMOLE-1302: Add support for forcing lossless compression on VNC/RDP connections.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #333:
URL: https://github.com/apache/guacamole-server/pull/333#discussion_r587042895
##########
File path: src/common/common/display.h
##########
@@ -228,5 +235,27 @@ void guac_common_display_free_layer(guac_common_display* display,
void guac_common_display_free_buffer(guac_common_display* display,
guac_common_display_layer* display_buffer);
+/**
+ * Sets the overall lossless compression policy of the given display to the
+ * given value, affecting all current and future layers/buffers maintained by
+ * the display. By default, newly-created displays will use lossy compression
+ * for graphical updates when heuristics determine that doing so is
+ * appropriate. Specifying a non-zero value here will force all graphical
+ * updates to always use lossless compression, whereas specifying zero will
+ * restore the default policy.
+ *
+ * Note that this can also be adjusted on a per-layer / per-buffer basis with
+ * guac_common_surface_set_lossless().
+ *
+ * @param display
+ * The display to modify
Review comment:
Oops. Fixed and rebased.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] jmuehlner merged pull request #333: GUACAMOLE-1302: Add support for forcing lossless compression on VNC/RDP connections.
Posted by GitBox <gi...@apache.org>.
jmuehlner merged pull request #333:
URL: https://github.com/apache/guacamole-server/pull/333
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] jmuehlner commented on a change in pull request #333: GUACAMOLE-1302: Add support for forcing lossless compression on VNC/RDP connections.
Posted by GitBox <gi...@apache.org>.
jmuehlner commented on a change in pull request #333:
URL: https://github.com/apache/guacamole-server/pull/333#discussion_r587037175
##########
File path: src/common/common/display.h
##########
@@ -228,5 +235,27 @@ void guac_common_display_free_layer(guac_common_display* display,
void guac_common_display_free_buffer(guac_common_display* display,
guac_common_display_layer* display_buffer);
+/**
+ * Sets the overall lossless compression policy of the given display to the
+ * given value, affecting all current and future layers/buffers maintained by
+ * the display. By default, newly-created displays will use lossy compression
+ * for graphical updates when heuristics determine that doing so is
+ * appropriate. Specifying a non-zero value here will force all graphical
+ * updates to always use lossless compression, whereas specifying zero will
+ * restore the default policy.
+ *
+ * Note that this can also be adjusted on a per-layer / per-buffer basis with
+ * guac_common_surface_set_lossless().
+ *
+ * @param display
+ * The display to modify
Review comment:
Looks like there's a period missing here on this param doc - same as `guac_common_surface_set_lossless`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org