You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by aaronzimmerman <gi...@git.apache.org> on 2014/05/30 15:47:17 UTC

[GitHub] incubator-storm pull request: Expose managed spout ids publicly

GitHub user aaronzimmerman opened a pull request:

    https://github.com/apache/incubator-storm/pull/129

    Expose managed spout ids publicly

    I'd like to do some work with topology visualization and also make the UI more useful for trident topologies.  The first issue I've run into is not being able to get a more friendly name from the spouts under the umbrella of a MasterBatchCoordinator.  

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aaronzimmerman/incubator-storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-storm/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #129
    
----
commit 2d64f7e80585281e64514d1be4f5efae83e7a9a4
Author: Aaron Zimmerman <az...@sproutsocial.com>
Date:   2014-05-30T12:39:10Z

    Expose managed spout ids publicly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-storm pull request: STORM-337 Expose managed spout ids p...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-storm/pull/129


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-storm pull request: Expose managed spout ids publicly

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/129#issuecomment-45088024
  
    I think the change looks fine to me.  All pull requests need a JIRA associated with them.  Please file a JIRA in http://issues.apache.org/jira if there is not one already there then add the jira number, aka STORM-...., to the title of this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-storm pull request: STORM-337 Expose managed spout ids p...

Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:

    https://github.com/apache/incubator-storm/pull/129#issuecomment-46619780
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-storm pull request: STORM-337 Expose managed spout ids p...

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/129#issuecomment-45412886
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---