You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/07/27 06:48:42 UTC
[kudu-CR] [common] add FindColumn for Schecma
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13936
Change subject: [common] add FindColumn for Schecma
......................................................................
[common] add FindColumn for Schecma
There are several implementations of FindColumn,
now add it as a member of Schecma.
Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
---
M src/kudu/client/scan_batch.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/row_operations-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/master/master_service.cc
7 files changed, 45 insertions(+), 51 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/13936/1
--
To view, visit http://gerrit.cloudera.org:8080/13936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
Gerrit-Change-Number: 13936
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
[kudu-CR] [common] add FindColumn for Schecma
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13936
to look at the new patch set (#2).
Change subject: [common] add FindColumn for Schecma
......................................................................
[common] add FindColumn for Schecma
There are several implementations of FindColumn,
now add it as a member of Schecma.
Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
---
M src/kudu/client/scan_batch.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/row_operations-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/master/master_service.cc
7 files changed, 47 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/13936/2
--
To view, visit http://gerrit.cloudera.org:8080/13936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
Gerrit-Change-Number: 13936
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [common] add FindColumn for Schecma
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13936 )
Change subject: [common] add FindColumn for Schecma
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13936/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13936/2//COMMIT_MSG@7
PS2, Line 7: Schecma
Schema
http://gerrit.cloudera.org:8080/#/c/13936/2//COMMIT_MSG@10
PS2, Line 10: now add it as a member of Schecma.
Schema
http://gerrit.cloudera.org:8080/#/c/13936/2/src/kudu/common/schema.h
File src/kudu/common/schema.h:
http://gerrit.cloudera.org:8080/#/c/13936/2/src/kudu/common/schema.h@509
PS2, Line 509: Status FindColumn(const Slice& col_name, int* idx) const;
Doc.
Also, you can pass col_name by value; Slices are small enough that it's probably more efficient to copy than to indirect.
--
To view, visit http://gerrit.cloudera.org:8080/13936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
Gerrit-Change-Number: 13936
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 28 Jul 2019 22:01:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [common] add FindColumn for Schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13936
to look at the new patch set (#3).
Change subject: [common] add FindColumn for Schema
......................................................................
[common] add FindColumn for Schema
There are several implementations of FindColumn,
now add it as a member of Schema.
Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
---
M src/kudu/client/scan_batch.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/row_operations-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/master/master_service.cc
7 files changed, 49 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/13936/3
--
To view, visit http://gerrit.cloudera.org:8080/13936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
Gerrit-Change-Number: 13936
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [common] add FindColumn for Schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13936 )
Change subject: [common] add FindColumn for Schema
......................................................................
[common] add FindColumn for Schema
There are several implementations of FindColumn,
now add it as a member of Schema.
Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
Reviewed-on: http://gerrit.cloudera.org:8080/13936
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/scan_batch.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/row_operations-test.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/master/master_service.cc
7 files changed, 49 insertions(+), 50 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
Gerrit-Change-Number: 13936
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [common] add FindColumn for Schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13936 )
Change subject: [common] add FindColumn for Schema
......................................................................
Patch Set 3:
(3 comments)
> Patch Set 3:
>
> Build Started http://jenkins.kudu.apache.org/job/kudu-gerrit/18395/
http://gerrit.cloudera.org:8080/#/c/13936/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13936/2//COMMIT_MSG@7
PS2, Line 7: Schema
> Schema
Done
http://gerrit.cloudera.org:8080/#/c/13936/2//COMMIT_MSG@10
PS2, Line 10: now add it as a member of Schema.
> Schema
Done
http://gerrit.cloudera.org:8080/#/c/13936/2/src/kudu/common/schema.h
File src/kudu/common/schema.h:
http://gerrit.cloudera.org:8080/#/c/13936/2/src/kudu/common/schema.h@509
PS2, Line 509: // Find the column index corresponding to the given column name,
> Doc.
Done
--
To view, visit http://gerrit.cloudera.org:8080/13936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
Gerrit-Change-Number: 13936
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Mon, 29 Jul 2019 05:53:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] [common] add FindColumn for Schema
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13936 )
Change subject: [common] add FindColumn for Schema
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iede12b95b774754f914295cecd2f6797008fed46
Gerrit-Change-Number: 13936
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Mon, 29 Jul 2019 18:17:56 +0000
Gerrit-HasComments: No