[GitHub] [geode] gaussianrecurrence commented on a change in pull request #5725: GEODE-8664: Nest errors in DistributionImpl.start

[GitBox <gi...@apache.org>]

gaussianrecurrence commented on a change in pull request #5725:
URL: https://github.com/apache/geode/pull/5725#discussion_r520747246



##########
File path: geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionTest.java
##########
@@ -204,4 +207,30 @@ public void testSendToEmptyListIsRejected() throws Exception {
     distribution.send(emptyList, m);
     verify(membership, never()).send(any(), any());
   }
+
+  @Test
+  public void testExceptionNestedOnStartConfigError() throws Exception {
+    Throwable cause = new RuntimeException("Exception cause");
+    Throwable exception = new MembershipConfigurationException("Test exception", cause);
+    doThrow(exception).when(membership).start();
+    try {

Review comment:
       Thanks for the comment! TBH I’ve never used JUnit or mockito before, so any comments are welcome!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org