You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Panagiotis Garefalakis (Jira)" <ji...@apache.org> on 2020/04/16 20:03:00 UTC
[jira] [Comment Edited] (HIVE-23210) Fix shortestjobcomparator when
jobs submitted have 1 task their vertices
[ https://issues.apache.org/jira/browse/HIVE-23210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085219#comment-17085219 ]
Panagiotis Garefalakis edited comment on HIVE-23210 at 4/16/20, 8:02 PM:
-------------------------------------------------------------------------
[~gopalv] thanks for the comment! You are right, the negative sign can indeed complicate things there.
Reworked the patch to handle single-task DAGs as a separate case and added an extra test for multi- vs single-task comparison: [https://github.com/apache/hive/pull/984/files#diff-ae97ef12823d4e9f10f596a95340cb3cR318]
Please let me know what you think.
was (Author: pgaref):
[~gopalv] thanks for the comment! You are right, the negative sign can indeed complicate things there.
Reworked the patch to handle single-task DAGs as a separate case and added an extra test for multi- vs single-task comparison: [https://github.com/apache/hive/pull/984/files#diff-ae97ef12823d4e9f10f596a95340cb3cR318]
Please let me know what you think.
> Fix shortestjobcomparator when jobs submitted have 1 task their vertices
> ------------------------------------------------------------------------
>
> Key: HIVE-23210
> URL: https://issues.apache.org/jira/browse/HIVE-23210
> Project: Hive
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23210.01.patch, TestShortestJobFirstComparator.java
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In latency sensitive queries, lots of jobs can have vertices with 1 task. Currently shortestjobcomparator does not work correctly and returns tasks in random order.
> [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/comparator/ShortestJobFirstComparator.java#L51]
> This causes delay in the job runtime. I will attach a simple test case shortly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)