You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/12/02 06:44:14 UTC
[GitHub] [kylin] nichunen commented on a change in pull request #961:
KYLIN-4167 Phase2
nichunen commented on a change in pull request #961: KYLIN-4167 Phase2
URL: https://github.com/apache/kylin/pull/961#discussion_r352431482
##########
File path: stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/assign/AssignmentsCache.java
##########
@@ -30,54 +33,70 @@
import org.apache.kylin.stream.coordinator.StreamMetadataStoreFactory;
import com.google.common.collect.Lists;
-import com.google.common.collect.Maps;
import org.apache.kylin.stream.core.model.CubeAssignment;
import org.apache.kylin.stream.core.model.ReplicaSet;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+/**
+ * Introduce AssignmentsCache to reduce pressure of
+ * @see StreamMetadataStore .
+ */
public class AssignmentsCache {
- private static volatile AssignmentsCache instance = new AssignmentsCache();
Review comment:
why remove "volatile"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services