You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2014/02/03 15:51:29 UTC
svn commit: r1563936 - in /qpid/jms/trunk/src:
main/java/org/apache/qpid/jms/engine/AmqpMessage.java
test/java/org/apache/qpid/jms/MessageIntegrationTest.java
test/java/org/apache/qpid/jms/engine/AmqpMessageTest.java
Author: robbie
Date: Mon Feb 3 14:51:29 2014
New Revision: 1563936
URL: http://svn.apache.org/r1563936
Log:
QPIDJMS-9: use new UnsignedLong.valueOf(BigInteger) method since added to Proton.
Modified:
qpid/jms/trunk/src/main/java/org/apache/qpid/jms/engine/AmqpMessage.java
qpid/jms/trunk/src/test/java/org/apache/qpid/jms/MessageIntegrationTest.java
qpid/jms/trunk/src/test/java/org/apache/qpid/jms/engine/AmqpMessageTest.java
Modified: qpid/jms/trunk/src/main/java/org/apache/qpid/jms/engine/AmqpMessage.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/main/java/org/apache/qpid/jms/engine/AmqpMessage.java?rev=1563936&r1=1563935&r2=1563936&view=diff
==============================================================================
--- qpid/jms/trunk/src/main/java/org/apache/qpid/jms/engine/AmqpMessage.java (original)
+++ qpid/jms/trunk/src/main/java/org/apache/qpid/jms/engine/AmqpMessage.java Mon Feb 3 14:51:29 2014
@@ -486,8 +486,7 @@ public abstract class AmqpMessage
throw new IllegalArgumentException("Value \""+messageId+"\" lies outside the range [0 - 2^64).");
}
- //TODO: add UnsignedLong.valueOf(BigInteger)?
- setUnderlyingMessageId(UnsignedLong.valueOf(messageId.toString()));
+ setUnderlyingMessageId(UnsignedLong.valueOf(messageId));
}
/**
Modified: qpid/jms/trunk/src/test/java/org/apache/qpid/jms/MessageIntegrationTest.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/test/java/org/apache/qpid/jms/MessageIntegrationTest.java?rev=1563936&r1=1563935&r2=1563936&view=diff
==============================================================================
--- qpid/jms/trunk/src/test/java/org/apache/qpid/jms/MessageIntegrationTest.java (original)
+++ qpid/jms/trunk/src/test/java/org/apache/qpid/jms/MessageIntegrationTest.java Mon Feb 3 14:51:29 2014
@@ -500,7 +500,7 @@ public class MessageIntegrationTest exte
if(underlyingAmqpMessageId instanceof BigInteger)
{
//Proton uses UnsignedLong
- underlyingAmqpMessageId = UnsignedLong.valueOf(underlyingAmqpMessageId.toString());
+ underlyingAmqpMessageId = UnsignedLong.valueOf((BigInteger)underlyingAmqpMessageId);
}
PropertiesDescribedType props = new PropertiesDescribedType();
Modified: qpid/jms/trunk/src/test/java/org/apache/qpid/jms/engine/AmqpMessageTest.java
URL: http://svn.apache.org/viewvc/qpid/jms/trunk/src/test/java/org/apache/qpid/jms/engine/AmqpMessageTest.java?rev=1563936&r1=1563935&r2=1563936&view=diff
==============================================================================
--- qpid/jms/trunk/src/test/java/org/apache/qpid/jms/engine/AmqpMessageTest.java (original)
+++ qpid/jms/trunk/src/test/java/org/apache/qpid/jms/engine/AmqpMessageTest.java Mon Feb 3 14:51:29 2014
@@ -717,7 +717,7 @@ public class AmqpMessageTest extends Qpi
else if(testMessageId instanceof BigInteger)
{
//The proton message uses an UnsignedLong wrapper
- underlyingIdObject = UnsignedLong.valueOf(((BigInteger) testMessageId).toString());
+ underlyingIdObject = UnsignedLong.valueOf((BigInteger) testMessageId);
}
Message message = Proton.message();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org