You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2024/11/20 17:40:27 UTC
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22085
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
Calls to both of these RPC endpoints are previously logged at
VLOG_RPC (or VLOG(2)). This patch change the log level to VLOG_QUERY (or
VLOG(1)). This is helpful because both RPC are usually called after
query execution complete, but the query handle is not relesed yet. They
are also rarely called by client, so they will not be too noisy. Missing
query driver log in GetAllQueryHandles is moved to its caller, where the
log message is clarified.
ImpalaShell._execute_stmt() also modified to call get_runtime_profile()
only if show_profile option is true.
Testing:
- Using impala-shell, run a TPC-DS query followed by 'profile' and
summary command. Verify that logs are printed, both with beeswax and
HS2 protocol.
- Pass core tests.
Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
---
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.cc
M shell/impala_shell.py
4 files changed, 16 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/22085/1
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11158/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 17:17:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11162/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 23:50:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 17:00:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11158/
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 22:40:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2024 05:23:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22085/2/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
http://gerrit.cloudera.org:8080/#/c/22085/2/be/src/service/impala-server.cc@1783
PS2, Line 1783: return Status::Expected(TErrorCode::INVALID_QUERY_HANDLE, PrintId(query_id));
> Yes, it is replaced with 2 LOG lines at L840 and L1051. GetAllQueryHandles
Ack
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 18:49:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 23:50:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#2) to the change originally created by Riza Suminto. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
Calls to both of these RPC endpoints are previously logged at
VLOG_RPC (or VLOG(2)). This patch change the log level to VLOG_QUERY (or
VLOG(1)). This is helpful because both RPC are usually called after
query execution complete, but the query handle is not released yet. They
are also rarely called by client, so they will not be too noisy. Missing
query driver log in GetAllQueryHandles is moved to its caller, where the
log message is clarified.
ImpalaShell._execute_stmt() also modified to call get_runtime_profile()
only if show_profile option is true.
Testing:
- Using impala-shell, run a TPC-DS query followed by 'profile' and
summary command. Verify that logs are printed, both with beeswax and
HS2 protocol.
- Pass core tests.
Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
---
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.cc
M shell/impala_shell.py
4 files changed, 16 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/22085/2
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22085/2/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
http://gerrit.cloudera.org:8080/#/c/22085/2/be/src/service/impala-server.cc@1783
PS2, Line 1783: return Status::Expected(TErrorCode::INVALID_QUERY_HANDLE, PrintId(query_id));
Commit message doesn't mention why this was changed. I assume it's already logged somewhere?
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 18:41:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22085/2/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
http://gerrit.cloudera.org:8080/#/c/22085/2/be/src/service/impala-server.cc@1783
PS2, Line 1783: return Status::Expected(TErrorCode::INVALID_QUERY_HANDLE, PrintId(query_id));
Yes, it is replaced with 2 LOG lines at L840 and L1051. GetAllQueryHandles only called in these 2 callsites.
In commit message:
> Missing query driver log in GetAllQueryHandles is moved to its caller, where the log message is clarified.
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 18:46:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
Calls to both of these RPC endpoints are previously logged at
VLOG_RPC (or VLOG(2)). This patch change the log level to VLOG_QUERY (or
VLOG(1)). This is helpful because both RPC are usually called after
query execution complete, but the query handle is not released yet. They
are also rarely called by client, so they will not be too noisy. Missing
query driver log in GetAllQueryHandles is moved to its caller, where the
log message is clarified.
ImpalaShell._execute_stmt() also modified to call get_runtime_profile()
only if show_profile option is true.
Testing:
- Using impala-shell, run a TPC-DS query followed by 'profile' and
summary command. Verify that logs are printed, both with beeswax and
HS2 protocol.
- Pass core tests.
Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Reviewed-on: http://gerrit.cloudera.org:8080/22085
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.cc
M shell/impala_shell.py
4 files changed, 16 insertions(+), 9 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/17519/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Nov 2024 17:57:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
Patch Set 4:
Pretty sure the test_async_load failure is unrelated. I'll try it out locally in a bit, then re-run the tests.
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Nov 2024 22:43:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG QUERY
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22085 )
Change subject: IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
......................................................................
IMPALA-13556: Log GetRuntimeProfile and GetExecSummary at VLOG_QUERY
Calls to both of these RPC endpoints are previously logged at
VLOG_RPC (or VLOG(2)). This patch change the log level to VLOG_QUERY (or
VLOG(1)). This is helpful because both RPC are usually called after
query execution complete, but the query handle is not released yet. They
are also rarely called by client, so they will not be too noisy. Missing
query driver log in GetAllQueryHandles is moved to its caller, where the
log message is clarified.
ImpalaShell._execute_stmt() also modified to call get_runtime_profile()
only if show_profile option is true.
Testing:
- Using impala-shell, run a TPC-DS query followed by 'profile' and
summary command. Verify that logs are printed, both with beeswax and
HS2 protocol.
- Pass core tests.
Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Reviewed-on: http://gerrit.cloudera.org:8080/22085
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.cc
M shell/impala_shell.py
4 files changed, 16 insertions(+), 9 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I90ef7d0fadd81c58ec1072e53430f51fea146cf1
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>