You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2009/12/05 00:11:20 UTC
[jira] Created: (MYFACES-2450) ViewHandler.deriveViewId must check
is viewId really exists
ViewHandler.deriveViewId must check is viewId really exists
-----------------------------------------------------------
Key: MYFACES-2450
URL: https://issues.apache.org/jira/browse/MYFACES-2450
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.0.0-alpha
Reporter: Leonardo Uribe
Assignee: Leonardo Uribe
ViewHandler.deriveViewId must check is viewId really exists.
Actually, we are using this method on RestoreViewExecutor to retrieve a valid vdl instance. But it seems the intention of this method is be called from NavigationHandlerImpl.
The effect of do not check is that if there is a commandButton or link with an action="someString" and this string does not point to any page and someString.jsp/someString.xhtml does not exists (derived from preemptive navigation), a 404 response happens, and the normal case has been always execute a postback.
Note that if we call it from RestoreViewExecutor and we check for file, TCK will fail because some tests create dummy views. The solution is add a proper method in RestoreViewSupport to deal with this fact (do the same as deriveViewId, but do not check).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2450) ViewHandler.deriveViewId must check
is viewId really exists
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-2450.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-alpha-2
> ViewHandler.deriveViewId must check is viewId really exists
> -----------------------------------------------------------
>
> Key: MYFACES-2450
> URL: https://issues.apache.org/jira/browse/MYFACES-2450
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-alpha
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Fix For: 2.0.0-alpha-2
>
>
> ViewHandler.deriveViewId must check is viewId really exists.
> Actually, we are using this method on RestoreViewExecutor to retrieve a valid vdl instance. But it seems the intention of this method is be called from NavigationHandlerImpl.
> The effect of do not check is that if there is a commandButton or link with an action="someString" and this string does not point to any page and someString.jsp/someString.xhtml does not exists (derived from preemptive navigation), a 404 response happens, and the normal case has been always execute a postback.
> Note that if we call it from RestoreViewExecutor and we check for file, TCK will fail because some tests create dummy views. The solution is add a proper method in RestoreViewSupport to deal with this fact (do the same as deriveViewId, but do not check).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.