You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "XuNeo (via GitHub)" <gi...@apache.org> on 2024/06/04 06:20:33 UTC

[PR] mm: check double free before adding to delaylist [nuttx]

XuNeo opened a new pull request, #12449:
URL: https://github.com/apache/nuttx/pull/12449

   ## Summary
   
   If free memory is delayed, check case of double free in the first place.
   
   ## Impact
   
   No.
   
   ## Testing
   
   Tested on internal project.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] mm: check double free before adding to delaylist [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12449:
URL: https://github.com/apache/nuttx/pull/12449#issuecomment-2147444163

   @XuNeo please include the Summay text in the commit message


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] mm: check double free before adding to delaylist [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #12449:
URL: https://github.com/apache/nuttx/pull/12449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] mm: check double free before adding to delaylist [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12449:
URL: https://github.com/apache/nuttx/pull/12449#discussion_r1625530204


##########
mm/mm_heap/mm_free.c:
##########
@@ -44,6 +44,13 @@ static void add_delaylist(FAR struct mm_heap_s *heap, FAR void *mem)
   FAR struct mm_delaynode_s *tmp = mem;
   irqstate_t flags;
 
+#  ifdef CONFIG_DEBUG_ASSERTIONS

Review Comment:
   add_delaylist() out of mm_lock() protected, move the check block after line 56.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org