[jira] [Commented] (METRON-123) Pycapa deploy needs to know the Kafka brokers url

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339459#comment-15339459 ] 

ASF GitHub Bot commented on METRON-123:
---------------------------------------

Github user cestella commented on the issue:

    https://github.com/apache/incubator-metron/pull/161
  
    So, a couple of things.  Please refactor this into separate PRs associated with JIRAs.  As of now, it's just impossible to review and we don't really know what we're getting.  It looks like a bunch of parsers, so maybe one JIRA per parser?  Also, name the PRs with the JIRA name as the first part of the name.  For instance, if your JIRA is METRON-123, then PR should be METRON-123: description.
    
    Thanks for the contribution, though!


> Pycapa deploy needs to know the Kafka brokers url
> -------------------------------------------------
>
>                 Key: METRON-123
>                 URL: https://issues.apache.org/jira/browse/METRON-123
>             Project: Metron
>          Issue Type: Bug
>            Reporter: David M. Lyle
>            Assignee: David M. Lyle
>
> ambari_gather_facts needs to be called during a full install when the Ansible pycapa task is include.
> TASK [pycapa : Install service script] *****************************************
> fatal: [ec2-52-34-37-199.us-west-2.compute.amazonaws.com]: FAILED! => {"changed": false, "failed": true, "msg": "AnsibleUndefinedVariable: ERROR! 'kafka_broker_url' is undefined"}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)