You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2012/12/06 08:18:40 UTC
[Bug 54254] New: Check AsyncRequestWorkerFactor to make the checking
style consistent
https://issues.apache.org/bugzilla/show_bug.cgi?id=54254
Bug ID: 54254
Summary: Check AsyncRequestWorkerFactor to make the checking
style consistent
Product: Apache httpd-2
Version: 2.4.3
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: mpm_event
Assignee: bugs@httpd.apache.org
Reporter: jackie.qq.zhang@gmail.com
Classification: Unclassified
Created attachment 29712
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29712&action=edit
a simple checker for AsyncRequestWorkerFactor
Hi,
In mpm_event (server/mpm/event/event.c), there're some minor checking problem
for the AsyncRequestWorkerFactor directive, which makes the configuration
checking style inconsistent.
Basically, if the input is a negative value, the code converts it to a super
big unsigned integer. I suggest to add a checker like all the other module
directives do. For example, LimitRequestLine, LimitRequestFieldsize,
CacheMin/MaxFileSize, etc. I personally really like the idea of careful
checking in Apache httpd.
The patch is really simple and tested.
Thanks,
Jackie
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54254] Check AsyncRequestWorkerFactor to make the checking
style consistent
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54254
Jackie Zhang <ja...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jackie.qq.zhang@gmail.com
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54254] Check AsyncRequestWorkerFactor to make the checking
style consistent
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54254
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Christophe JAILLET <ch...@wanadoo.fr> ---
Backported in 2.4.x in r1502204.
Is part of 2.4.5
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 54254] Check AsyncRequestWorkerFactor to make the checking
style consistent
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54254
Stefan Fritsch <sf...@sfritsch.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |FixedInTrunk
--- Comment #1 from Stefan Fritsch <sf...@sfritsch.de> ---
Thanks, committed as r1425777 (without the explanation of
AsyncRequestWorkerFactor, which I think is too simplified).
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org