Re: [PR] [SPARK-45425] Mapped TINYINT to ByteType for MsSqlServerDialect [spark]

["zeruibao (via GitHub)" <gi...@apache.org>]

zeruibao commented on code in PR #43232:
URL: https://github.com/apache/spark/pull/43232#discussion_r1348018735


##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala:
##########
@@ -109,7 +109,7 @@ private object MsSqlServerDialect extends JdbcDialect {
         None
       } else {
         sqlType match {
-          case java.sql.Types.SMALLINT => Some(ShortType)
+          case java.sql.Types.SMALLINT | java.sql.Types.TINYINT => Some(ShortType)

Review Comment:
   Yeah agree. Let me make this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org