You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "aditya87 (GitHub)" <gi...@apache.org> on 2018/10/30 18:51:43 UTC

[GitHub] [geode] aditya87 opened pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

- Add getRootRegion default method to Region interface.

Signed-off-by: Jens Deppe <jd...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
drop the extra parens

[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
in addition to verify the resulting xml, you can also start a third server, and verifies that on the 3rd server the region "regionName/subRegionName/subSubRegionName" exists.

[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "aditya87 (GitHub)" <gi...@apache.org>.
This handles that case.

[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "metatype (GitHub)" <gi...@apache.org>.
It would be nice to create a unit test for this new API.

[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
I would not add this to Region since we want to deprecate subregions. Once subregions go away this method would always return null. Region is an external API that we need to keep supporting.


[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "aditya87 (GitHub)" <gi...@apache.org>.
Got it. We will move this code to some helper on the gfsh side for now.

[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal closed pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
[ pull request closed by jdeppe-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
How about just adding a method like getXmlEntityRegionName(Region) and calling that method on line 96 in place of "createdRegion.getName()". This method could do the code that finds the root region and returns the correct name. And that way this code will only create the xmlEntity once.

[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "aditya87 (GitHub)" <gi...@apache.org>.
Sure

[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "metatype (GitHub)" <gi...@apache.org>.
I'm not that familiar with this code but I'm wondering about the case when there are multiple parent regions (eg `root/parent1/parent2/subregion`).

[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2747: GEODE-5952: Provide full cache XML entity for root region when a subregion is created with gfsh

Posted by "aditya87 (GitHub)" <gi...@apache.org>.
Makes sense

[ Full content available at: https://github.com/apache/geode/pull/2747 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org