You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Kan Zhang (JIRA)" <ji...@apache.org> on 2009/05/16 02:09:45 UTC

[jira] Created: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
-----------------------------------------------------------------------

                 Key: HADOOP-5856
                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
             Project: Hadoop Core
          Issue Type: Bug
          Components: dfs
            Reporter: Kan Zhang
            Assignee: Kan Zhang


This JIRA fixes the following warning:

STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
Called method java.text.DateFormat.format(Date)
Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710043#action_12710043 ] 

Suresh Srinivas commented on HADOOP-5856:
-----------------------------------------

+1. Can you please fix the typo in the method name from {{newEnry}} to {{newEntry}}  

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-5856:
------------------------------

    Attachment: 5856-1.patch

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch, 5856-1.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5856:
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
           Status: Resolved  (was: Patch Available)

The failed tests are not related.  I have run TestDatanodeDeath a few times and it did not fail.

I have committed this.  Thanks, Kan!

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>             Fix For: 0.21.0
>
>         Attachments: 5856-0.patch, 5856-1.patch, 5856-2.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-5856:
------------------------------

    Status: Open  (was: Patch Available)

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch, 5856-1.patch, 5856-2.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5856:
-------------------------------------------

    Hadoop Flags: [Reviewed]

+1  	5856-2.patch looks good.

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch, 5856-1.patch, 5856-2.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-5856:
------------------------------

    Attachment: 5856-0.patch

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-5856:
------------------------------

    Attachment: 5856-2.patch

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch, 5856-1.patch, 5856-2.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713334#action_12713334 ] 

Hadoop QA commented on HADOOP-5856:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12408541/5856-2.patch
  against trunk revision 778811.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/405/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/405/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/405/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/405/console

This message is automatically generated.

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch, 5856-1.patch, 5856-2.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710952#action_12710952 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5856:
------------------------------------------------

I suggesting removing newEnry(..), i.e.
{code}
-      log.appendLine(LogEntry.newEnry(block, now));
+      log.appendLine("date=\"" + dateFormat.format(new Date(now)) + "\"\t " +
+          "time=\"" + now + "\"\t " +
+          "genstamp=\"" + block.getGenerationStamp() + "\"\t " +
+          "id=\"" + block.getBlockId() +"\"");
{code}


> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch, 5856-1.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710045#action_12710045 ] 

Kan Zhang commented on HADOOP-5856:
-----------------------------------

> Can you please fix the typo in the method name from newEnry to newEntry
done.

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch, 5856-1.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710962#action_12710962 ] 

Kan Zhang commented on HADOOP-5856:
-----------------------------------

good idea, new patch attached.

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch, 5856-1.patch, 5856-2.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-5856:
------------------------------

    Status: Patch Available  (was: Open)

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch, 5856-1.patch, 5856-2.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5856) FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs

Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kan Zhang updated HADOOP-5856:
------------------------------

    Status: Patch Available  (was: Open)

> FindBugs : fix "unsafe multithreaded use of DateFormat" warning in hdfs
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-5856
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5856
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: 5856-0.patch, 5856-1.patch
>
>
> This JIRA fixes the following warning:
> STCAL	Call to method of static java.text.DateFormat in org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Bug type STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE (click for details) 
> In class org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry
> In method org.apache.hadoop.hdfs.server.datanode.DataBlockScanner$LogEntry.newEnry(Block, long)
> Called method java.text.DateFormat.format(Date)
> Field org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.dateFormat
> At DataBlockScanner.java:[line 385]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.