You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2006/01/16 14:01:59 UTC
DO NOT REPLY [Bug 38287] New: - Configure encoding flexibly
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38287>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38287
Summary: Configure encoding flexibly
Product: JMeter
Version: 2.1.1
Platform: All
OS/Version: other
Status: NEW
Severity: enhancement
Priority: P2
Component: HTTP
AssignedTo: jmeter-dev@jakarta.apache.org
ReportedBy: kanekotky@yahoo.co.jp
I hope that I will be able to configure the encoding of request parameter not
only UTF-8 on JMeter.
I made a patche for this enhancement on JMeter 2.1.1. This patch will put the
text field for encoding on Http Request Sampler, Http Request Default
Configuration, and Http Proxy Server. Then it will carry encoding name from
GUI to JOrphanUtils. At the same time, this patch includes another one for
#38115.
This issue is very important for real web systems. There are a lot of systems
that doesn't use UTF8 encoding.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38287] - Configure encoding flexibly
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38287>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38287
sebb@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
------- Additional Comments From sebb@apache.org 2006-01-23 14:56 -------
(In reply to comment #4)
> Created an attachment (id=17487)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17487&action=view) [edit]
> This patch targets branch rel-2-1/src, revision 369906
> Thanks for checking.
I've not checked everything.
> I renew a patch that targets at the branch rel-2-1. As you said, there are
not
> so much changes. And it is fixed around MultipartUrlConfig.java.
> I want to change HTTPArgument constructors because the encoding value is
needed
> when we use the alreadyEncoded parameter.
> I really want to resolve this issue. Please let me know what can I do for it.
Sorry, but removing a public constructor is not backwards compatible.
A new constructor can be added if required.
Likewise, changing the meaning of the 3rd String parameter to addArgument() is
not backwards compatible. If necessary, please create a new method.
I found it confusing to have a field called "encode" - which sounds like a
boolean flag - it would be clearer to me as "encoding".
==
I'm not entirely clear why it is necessary to have an extra "encoding" field
on the HTTPSampler GUI. How do browsers know what encoding to use?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38287] - Configure encoding flexibly
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38287>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38287
------- Additional Comments From kanekotky@yahoo.co.jp 2006-01-23 08:04 -------
Created an attachment (id=17487)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17487&action=view)
This patch targets branch rel-2-1/src, revision 369906
Thanks for checking.
I renew a patch that targets at the branch rel-2-1. As you said, there are not
so much changes. And it is fixed around MultipartUrlConfig.java.
I want to change HTTPArgument constructors because the encoding value is needed
when we use the alreadyEncoded parameter.
I really want to resolve this issue. Please let me know what can I do for it.
Regards,
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38287] - Configure encoding flexibly
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38287>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38287
kanekotky@yahoo.co.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |ASSIGNED
------- Additional Comments From kanekotky@yahoo.co.jp 2006-03-04 14:11 -------
I forgot to change the status.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38287] - Configure encoding flexibly
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38287>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38287
------- Additional Comments From sebb@apache.org 2006-01-22 19:29 -------
(In reply to comment #2)
> I'm worry about the difference between version 2.1.1 and 2.1.2.
There are unlikely to be too many changes in this area.
> I hope that someone would check my patch before the difference will increase.
A brief check shows that the change to MultipartUrlConfig.java is not backwards
compatible. The patch changes the meaning of the 3-parameter addArgument() method.
Likewise, it changes the signature of 2 of the public HTTPArgument constructors.
Therefore I don't think the patch can be applied as it stands - it needs some
further work.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38287] - Configure encoding flexibly
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38287>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38287
------- Additional Comments From kanekotky@yahoo.co.jp 2006-01-21 14:24 -------
I'm worry about the difference between version 2.1.1 and 2.1.2.
I hope that someone would check my patch before the difference will increase.
Regards,
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38287] - Configure encoding flexibly
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38287>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38287
kanekotky@yahoo.co.jp changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #17431|0 |1
is obsolete| |
Attachment #17487|0 |1
is obsolete| |
------- Additional Comments From kanekotky@yahoo.co.jp 2006-01-28 00:53 -------
Created an attachment (id=17522)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17522&action=view)
updated patch
Thanks.
I have revised the patch based on your comments.
> I'm not entirely clear why it is necessary to have an
> extra "encoding" field on the HTTPSampler GUI.
> How do browsers know what encoding to use?
Browsers know the encoding from http header or meta tag.
But it is difficult for HttpProxy to manage encoding automatically.
I think the developers of the web system know what encoding to use.
So an extra encoding field is necessary for developers to configure encoding.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38287] - Configure encoding flexibly
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38287>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38287
sebb@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From sebb@apache.org 2007-06-28 13:52 -------
Encoding parameter has been added to Http samplers
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38287] - Configure encoding flexibly
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38287>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38287
------- Additional Comments From kanekotky@yahoo.co.jp 2006-01-16 14:05 -------
Created an attachment (id=17431)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17431&action=view)
This patch will allow to configure encoding.
Please check it out.
Regards,
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org