You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/06 11:34:07 UTC

[GitHub] [flink] zlzhang0122 opened a new pull request, #20183: [FLINK-24306][table]Group by index throw SqlValidatorException

zlzhang0122 opened a new pull request, #20183:
URL: https://github.com/apache/flink/pull/20183

   ## What is the purpose of the change
   
   *This pull request try to fix the SqlValidatorException when using group by index in Flink.*
   
   
   ## Brief change log
   
     - *Pass FlinkSqlConformance.DEFAULT to FlinkCalciteSqlValidator*
     - *Change the return value of isGroupByOrdinal() from false to true *
     - *Add unit test for these changes*
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change added tests and can be verified as follows:
   
     - *Added test class FlinkPlannerImplTest and function testCreateSqlValidator() *
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20183: [FLINK-24306][table]Group by index throw SqlValidatorException

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20183:
URL: https://github.com/apache/flink/pull/20183#issuecomment-1176118238

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c53501b02789548ee6799ddc85999306ac1244c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2c53501b02789548ee6799ddc85999306ac1244c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c53501b02789548ee6799ddc85999306ac1244c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zlzhang0122 commented on pull request #20183: [FLINK-24306][table]Group by index throw SqlValidatorException

Posted by GitBox <gi...@apache.org>.
zlzhang0122 commented on PR #20183:
URL: https://github.com/apache/flink/pull/20183#issuecomment-1176121877

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zlzhang0122 commented on pull request #20183: [FLINK-24306][table]Group by index throw SqlValidatorException

Posted by "zlzhang0122 (via GitHub)" <gi...@apache.org>.
zlzhang0122 commented on PR #20183:
URL: https://github.com/apache/flink/pull/20183#issuecomment-1442682491

   @wuchong Could you pls help to confirm and review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org