You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "w41ter (via GitHub)" <gi...@apache.org> on 2024/09/10 09:31:28 UTC

[PR] [fix](restore) Fix clean restore with view [doris]

w41ter opened a new pull request, #40620:
URL: https://github.com/apache/doris/pull/40620

   While the previous impl only considered OLAP tables, restore included ODBC and Views, both of which were not recorded in backupOlapTableObjects and were accidentally deleted.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) Fix clean restore with view [doris]

Posted by "w41ter (via GitHub)" <gi...@apache.org>.
w41ter commented on PR #40620:
URL: https://github.com/apache/doris/pull/40620#issuecomment-2340155629

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) Fix clean restore with view [doris]

Posted by "w41ter (via GitHub)" <gi...@apache.org>.
w41ter merged PR #40620:
URL: https://github.com/apache/doris/pull/40620


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) Fix clean restore with view [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40620:
URL: https://github.com/apache/doris/pull/40620#issuecomment-2347897552

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 197596 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 628e441ddbe274fd7605a2e3e96436dc079579ec, data reload: false
   
   query1	1267	882	875	875
   query2	6345	1845	1780	1780
   query3	10696	4009	3940	3940
   query4	57839	25886	23899	23899
   query5	4989	547	527	527
   query6	298	170	166	166
   query7	5593	308	295	295
   query8	278	207	210	207
   query9	6064	2584	2586	2584
   query10	407	280	269	269
   query11	16021	15463	15489	15463
   query12	156	103	101	101
   query13	1459	409	444	409
   query14	10260	6538	7079	6538
   query15	222	181	188	181
   query16	7101	526	509	509
   query17	1138	600	611	600
   query18	1944	310	298	298
   query19	216	157	155	155
   query20	125	118	117	117
   query21	206	109	113	109
   query22	4968	4551	4793	4551
   query23	34644	33737	33853	33737
   query24	6152	3048	3142	3048
   query25	495	389	399	389
   query26	605	152	152	152
   query27	1591	281	279	279
   query28	2811	2094	2071	2071
   query29	660	418	408	408
   query30	224	154	155	154
   query31	982	780	778	778
   query32	69	53	53	53
   query33	445	288	304	288
   query34	899	472	470	470
   query35	843	728	727	727
   query36	1030	896	898	896
   query37	136	79	77	77
   query38	4097	3788	3869	3788
   query39	1446	1402	1388	1388
   query40	206	111	111	111
   query41	46	45	46	45
   query42	123	99	98	98
   query43	490	446	458	446
   query44	1187	811	784	784
   query45	196	165	169	165
   query46	1092	854	815	815
   query47	1934	1790	1830	1790
   query48	376	292	288	288
   query49	723	442	435	435
   query50	939	443	441	441
   query51	6935	6983	6920	6920
   query52	100	87	91	87
   query53	250	180	184	180
   query54	558	475	462	462
   query55	74	76	77	76
   query56	277	264	280	264
   query57	1224	1056	1088	1056
   query58	227	229	243	229
   query59	2750	2678	2601	2601
   query60	294	269	280	269
   query61	104	102	100	100
   query62	809	683	674	674
   query63	217	186	181	181
   query64	1550	719	649	649
   query65	3236	3159	3175	3159
   query66	679	292	310	292
   query67	15929	15729	15371	15371
   query68	2018	559	568	559
   query69	399	276	279	276
   query70	1211	1111	1107	1107
   query71	340	283	275	275
   query72	4617	4022	2469	2469
   query73	771	326	325	325
   query74	9309	9088	9007	9007
   query75	3359	2706	2731	2706
   query76	1332	1338	1327	1327
   query77	500	320	312	312
   query78	9963	9395	9571	9395
   query79	949	893	887	887
   query80	889	844	827	827
   query81	490	268	260	260
   query82	270	271	274	271
   query83	210	187	186	186
   query84	270	107	107	107
   query85	731	440	393	393
   query86	348	297	325	297
   query87	4451	4480	4323	4323
   query88	4267	4177	4180	4177
   query89	377	374	370	370
   query90	2020	313	311	311
   query91	122	126	122	122
   query92	79	76	77	76
   query93	1048	1052	1050	1050
   query94	767	365	390	365
   query95	490	424	425	424
   query96	479	479	481	479
   query97	3136	3149	3125	3125
   query98	232	246	229	229
   query99	1707	1322	1295	1295
   Total cold run time: 294397 ms
   Total hot run time: 197596 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) Fix clean restore with view [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40620:
URL: https://github.com/apache/doris/pull/40620#issuecomment-2347906927

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) Fix clean restore with view [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40620:
URL: https://github.com/apache/doris/pull/40620#issuecomment-2340151619

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) Fix clean restore with view [doris]

Posted by "w41ter (via GitHub)" <gi...@apache.org>.
w41ter commented on PR #40620:
URL: https://github.com/apache/doris/pull/40620#issuecomment-2347821407

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) Fix clean restore with view [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40620:
URL: https://github.com/apache/doris/pull/40620#issuecomment-2347881332

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 42733 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 628e441ddbe274fd7605a2e3e96436dc079579ec, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17608	7264	7202	7202
   q2	2061	183	173	173
   q3	10490	1212	1393	1212
   q4	10320	968	985	968
   q5	7719	3161	3146	3146
   q6	235	150	148	148
   q7	1071	638	637	637
   q8	9461	1983	2007	1983
   q9	6769	6315	6283	6283
   q10	7047	2516	2528	2516
   q11	425	253	247	247
   q12	405	226	232	226
   q13	17752	3008	2992	2992
   q14	289	240	247	240
   q15	578	530	535	530
   q16	499	436	434	434
   q17	977	939	948	939
   q18	7410	6860	6818	6818
   q19	1389	1233	1232	1232
   q20	622	350	335	335
   q21	3921	3506	3482	3482
   q22	1067	1002	990	990
   Total cold run time: 108115 ms
   Total hot run time: 42733 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7151	7151	7121	7121
   q2	338	233	243	233
   q3	3058	3107	2988	2988
   q4	2065	2145	2038	2038
   q5	5660	5592	5698	5592
   q6	235	149	155	149
   q7	2177	1762	1767	1762
   q8	3354	3426	3427	3426
   q9	8847	8922	8832	8832
   q10	3439	3597	3573	3573
   q11	599	484	498	484
   q12	803	643	640	640
   q13	9468	3182	3151	3151
   q14	321	291	290	290
   q15	575	538	548	538
   q16	543	479	462	462
   q17	1801	1761	1759	1759
   q18	8461	8088	8171	8088
   q19	1757	1741	1743	1741
   q20	2113	1894	1898	1894
   q21	5868	5568	5704	5568
   q22	1121	1061	1071	1061
   Total cold run time: 69754 ms
   Total hot run time: 61390 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) Fix clean restore with view [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40620:
URL: https://github.com/apache/doris/pull/40620#issuecomment-2347902285

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.9 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 628e441ddbe274fd7605a2e3e96436dc079579ec, data reload: false
   
   query1	0.05	0.04	0.04
   query2	0.08	0.04	0.04
   query3	0.22	0.05	0.05
   query4	1.69	0.06	0.07
   query5	0.50	0.50	0.51
   query6	1.13	0.73	0.75
   query7	0.01	0.01	0.01
   query8	0.05	0.04	0.04
   query9	0.56	0.51	0.52
   query10	0.58	0.61	0.56
   query11	0.16	0.12	0.12
   query12	0.14	0.12	0.12
   query13	0.62	0.61	0.60
   query14	1.48	1.49	1.47
   query15	0.91	0.86	0.87
   query16	0.36	0.37	0.36
   query17	1.04	1.02	1.04
   query18	0.16	0.15	0.16
   query19	1.96	1.80	1.87
   query20	0.01	0.02	0.01
   query21	15.39	0.67	0.65
   query22	3.79	6.90	2.22
   query23	17.96	1.42	1.28
   query24	2.27	0.21	0.21
   query25	0.18	0.08	0.08
   query26	0.28	0.19	0.17
   query27	0.08	0.07	0.08
   query28	13.17	1.14	1.09
   query29	12.54	3.36	3.35
   query30	0.25	0.06	0.05
   query31	2.90	0.41	0.42
   query32	3.23	0.50	0.49
   query33	3.01	3.08	3.05
   query34	15.44	4.30	4.31
   query35	4.35	4.35	4.42
   query36	0.68	0.47	0.50
   query37	0.20	0.15	0.16
   query38	0.16	0.15	0.15
   query39	0.05	0.04	0.04
   query40	0.17	0.15	0.13
   query41	0.10	0.05	0.05
   query42	0.06	0.06	0.05
   query43	0.05	0.04	0.04
   Total cold run time: 108.02 s
   Total hot run time: 31.9 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](restore) Fix clean restore with view [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40620:
URL: https://github.com/apache/doris/pull/40620#issuecomment-2347981741

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org