You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/07 04:24:14 UTC

[GitHub] [kafka] lbradstreet commented on a change in pull request #10333: KAFKA-12481: Add socket.nagle.disable config property

lbradstreet commented on a change in pull request #10333:
URL: https://github.com/apache/kafka/pull/10333#discussion_r627914726



##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -741,6 +743,7 @@ object KafkaConfig {
     "then controller will use \"broker1.example.com:9094\" with security protocol \"SSL\" to connect to the broker.\n" +
     "If not explicitly configured, the default value will be null and there will be no dedicated endpoints for controller connections."
 
+  val SocketTcpNoDelayDoc = "Enable the Nagle algorithm (TCP_NODELAY) on broker sockets."

Review comment:
       TCP_NODELAY disables the nagle algorithm, doesn't it? I think true is a bit misleading then.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org