You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/07 03:56:54 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #5441: Sharding-Proxy config and integrate metrics.
codecov-io commented on pull request #5441:
URL: https://github.com/apache/shardingsphere/pull/5441#issuecomment-625014805
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5441?src=pr&el=h1) Report
> Merging [#5441](https://codecov.io/gh/apache/shardingsphere/pull/5441?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b725f09192fda7ac3b055b9a24cb3798b6e1ae7e&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `5.40%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5441?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5441 +/- ##
============================================
- Coverage 53.50% 53.42% -0.08%
Complexity 418 418
============================================
Files 1171 1174 +3
Lines 21100 21133 +33
Branches 3818 3821 +3
============================================
+ Hits 11289 11291 +2
- Misses 9093 9124 +31
Partials 718 718
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5441?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ics/configuration/config/MetricsConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5441/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvY29uZmlndXJhdGlvbi9jb25maWcvTWV0cmljc0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ation/swapper/MetricsConfigurationYamlSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5441/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvY29uZmlndXJhdGlvbi9zd2FwcGVyL01ldHJpY3NDb25maWd1cmF0aW9uWWFtbFN3YXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...s/configuration/yaml/YamlMetricsConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5441/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLWNvbmZpZ3VyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvY29uZmlndXJhdGlvbi95YW1sL1lhbWxNZXRyaWNzQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...cs/prometheus/PrometheusMetricsTrackerManager.java](https://codecov.io/gh/apache/shardingsphere/pull/5441/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljc1RyYWNrZXJNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/shardingsphere/shardingproxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/5441/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3Byb3h5L0Jvb3RzdHJhcC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...roxy/config/yaml/YamlProxyServerConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5441/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3Byb3h5L2NvbmZpZy95YW1sL1lhbWxQcm94eVNlcnZlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ingsphere/metrics/facade/MetricsTrackerFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/5441/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLWZhY2FkZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWV0cmljcy9mYWNhZGUvTWV0cmljc1RyYWNrZXJGYWNhZGUuamF2YQ==) | `32.60% <25.00%> (+0.79%)` | `0.00 <0.00> (ø)` | |
| [...on/config/properties/ConfigurationPropertyKey.java](https://codecov.io/gh/apache/shardingsphere/pull/5441/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbmZpZy9wcm9wZXJ0aWVzL0NvbmZpZ3VyYXRpb25Qcm9wZXJ0eUtleS5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/shardingsphere/pull/5441/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5441?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5441?src=pr&el=footer). Last update [b725f09...95077d8](https://codecov.io/gh/apache/shardingsphere/pull/5441?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org