You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/07/29 07:17:09 UTC

[GitHub] [james-project] Arsnael commented on a change in pull request #557: [REFACTORING] UsersRepositoryContract

Arsnael commented on a change in pull request #557:
URL: https://github.com/apache/james-project/pull/557#discussion_r678886839



##########
File path: server/data/data-library/src/test/java/org/apache/james/user/lib/UsersRepositoryContract.java
##########
@@ -53,15 +54,12 @@
 
     class UserRepositoryExtension implements BeforeEachCallback, ParameterResolver {
 
-        private static final boolean ENABLE_VIRTUAL_HOSTING = true;
-        private static final boolean DISABLE_VIRTUAL_HOSTING = !ENABLE_VIRTUAL_HOSTING;

Review comment:
       why removing those explicit variables?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org